Skip to content

feat: add keyboard_scroll prop and expose auto scroll state#175

Merged
ccbrown merged 1 commit intoccbrown:mainfrom
domenkozar:feat/scroll-view-keyboard-scroll-and-auto-scroll-state
Mar 2, 2026
Merged

feat: add keyboard_scroll prop and expose auto scroll state#175
ccbrown merged 1 commit intoccbrown:mainfrom
domenkozar:feat/scroll-view-keyboard-scroll-and-auto-scroll-state

Conversation

@domenkozar
Copy link
Contributor

@domenkozar domenkozar commented Mar 1, 2026

Add keyboard_scroll prop to disable keyboard scrolling while keeping the hook registered for consistent ordering. Expose user_scrolled_up through the handle with a read only is_auto_scroll_pinned() getter, and update all handle scroll methods to consistently maintain auto scroll state based on the resulting scroll position.

@codecov
Copy link

codecov bot commented Mar 1, 2026

Codecov Report

❌ Patch coverage is 20.00000% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.84%. Comparing base (766e650) to head (56ce071).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/iocraft/src/components/scroll_view.rs 20.00% 20 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #175      +/-   ##
==========================================
- Coverage   89.06%   88.84%   -0.23%     
==========================================
  Files          34       34              
  Lines        5826     5843      +17     
  Branches     5826     5843      +17     
==========================================
+ Hits         5189     5191       +2     
- Misses        526      541      +15     
  Partials      111      111              
Files with missing lines Coverage Δ
packages/iocraft/src/components/scroll_view.rs 77.45% <20.00%> (-2.80%) ⬇️

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Add `keyboard_scroll` prop to disable keyboard scrolling while keeping
the hook registered for consistent ordering. Expose `user_scrolled_up`
through the handle with a read only `is_auto_scroll_pinned()` getter,
and update all handle scroll methods to consistently maintain auto scroll
state based on the resulting scroll position.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@domenkozar domenkozar force-pushed the feat/scroll-view-keyboard-scroll-and-auto-scroll-state branch from 8b3567d to 56ce071 Compare March 2, 2026 00:12
Copy link
Owner

@ccbrown ccbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@ccbrown ccbrown merged commit 5dd17c0 into ccbrown:main Mar 2, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants