Skip to content

Pin (keep open) button in full view - #346

Open
jojo-chaechae wants to merge 2 commits into
ccatterina:mainfrom
jojo-chaechae:upstream/pin-button
Open

jojo-chaechae wants to merge 2 commits into
ccatterina:mainfrom
jojo-chaechae:upstream/pin-button

Conversation

@jojo-chaechae

Copy link
Copy Markdown

Adds an optional pin/keep-open button to the full view popup.

Add an optional pin button to the full view popup. When pinned, the popup
stays open on deactivation.
@jojo-chaechae

jojo-chaechae commented Aug 13, 2026 •

Copy link
Copy Markdown
Author

especially useful if trying to change settings or take screenshots
edit: i would like help with the pin appearance before this is merged since this is very jank
https://github.com/user-attachments/assets/50fb4dcd-9491-4fde-9d31-cb38ee79fbf7
edit2 : closes #256

@ccatterina

ccatterina commented Sep 18, 2026 •

Copy link
Copy Markdown
Owner

Hi, thank you for the PR and sorry for the late reply.
I tested the PR and I think we should find a better position for the pin button. With the current implementation it can overlap with the album image or the player selector if enabled.

What do you say if we add a Keep open option to contextual actions menu?

Something like this:
image

@jojo-chaechae

Copy link
Copy Markdown
Author

I like this implementation better too, redoing it

@jojo-chaechae

Copy link
Copy Markdown
Author
image

property alias cfg_fullViewMinWidth: fullViewMinWidth.value
property alias cfg_fullViewMaxWidth: fullViewMaxWidth.value
property alias cfg_showPlayerSelector: showPlayerSelector.checked
property alias cfg_showPinButton: showPinButton.checked

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is no longer needed.

Suggested change
property alias cfg_showPinButton: showPinButton.checked

Comment thread src/contents/ui/Full.qml
}

}

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants