[rpc] Propagate insufficient balance error - #2527
Conversation
This patch propagates the insufficient balance error through the rpc stack rather than rewriting it to a generic "other" error type with a custom message.
There was a problem hiding this comment.
Pull request overview
Propagates the “insufficient balance” condition through the eth_call execution path by preserving a dedicated status code from the C++ executor into the Rust monad-ethcall layer (instead of collapsing it into a generic “other” error), aligning with the linked companion change in monad-bft.
Changes:
- Introduces an
EVMC_INSUFFICIENT_BALANCEstatus code mapping inmonad-ethcalland converts it into a dedicatedEthCallError::InsufficientBalance. - Updates the C++ RPC executor to return
EVMC_INSUFFICIENT_BALANCEforTransactionError::InsufficientBalance. - Adjusts the C++ RPC test to assert the new status code.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| rust/crates/monad-ethcall/src/executor/mod.rs | Adds the EVMC_INSUFFICIENT_BALANCE status code constant used by the Rust executor layer. |
| rust/crates/monad-ethcall/src/executor/call.rs | Adds EthCallError::InsufficientBalance and handles EVMC_INSUFFICIENT_BALANCE in the result status mapping. |
| category/rpc/monad_executor.cpp | Propagates TransactionError::InsufficientBalance as EVMC_INSUFFICIENT_BALANCE instead of EVMC_REJECTED. |
| category/rpc/monad_executor_test.cpp | Updates the insufficient-balance test expectation to the new status code. |
Verdict: NEEDS CHANGES
Generated with Claude Code
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| use std::f32::consts::E; | ||
|
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| pub(super) const ETH_CALL_SUCCESS: i32 = 0; | ||
| pub(super) const EVMC_OUT_OF_GAS: i32 = 3; | ||
| pub(super) const EVMC_INSUFFICIENT_BALANCE: i32 = 4; |
There was a problem hiding this comment.
[P1] Wrong evmc status-code value — EVMC_INSUFFICIENT_BALANCE is 17 in third_party/evmc/include/evmc/evmc.h, not 4 (4 is EVMC_INVALID_INSTRUCTION). As written, real insufficient-balance results (status 17 from the C++ side) fall through to the _ arm and never produce the new EthCallError::InsufficientBalance variant, while any call that fails with an invalid instruction is misclassified as insufficient balance.
| pub(super) const EVMC_INSUFFICIENT_BALANCE: i32 = 4; | |
| pub(super) const EVMC_INSUFFICIENT_BALANCE: i32 = 17; |
| // You should have received a copy of the GNU General Public License | ||
| // along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
|
|
||
| use std::f32::consts::E; |
There was a problem hiding this comment.
[P2] Unused import — std::f32::consts::E (Euler's number as an f32) is never used in this file and looks like an accidental IDE auto-import; it will trip the unused_imports lint. Delete the line (and the blank line after it).
| } else { | ||
| let trace = result.encoded_trace().map_err(|_| { | ||
| warn!("execution error `eth_call` failed: encoded trace pointer is null"); | ||
| EthCallError::InternalError | ||
| })?; | ||
| Err(EthCallError::Trace { trace }) | ||
| } |
There was a problem hiding this comment.
[P2] With a non-NOOP tracer this branch returns InternalError for the validation-path insufficient balance introduced on the C++ side. Unlike EVMC_MONAD_RESERVE_BALANCE_VIOLATION (which only arises during execution, where a trace exists), EVMC_INSUFFICIENT_BALANCE now also arrives from the pre-execution TransactionError path in monad_executor.cpp, where no trace is produced (monad_executor_test.cpp asserts encoded_trace_len == 0 for this case) — so encoded_trace() fails and the caller gets InternalError plus a spurious warn log, where it previously got Other { message: "insufficient balance" } via the _ arm. Consider falling back to EthCallError::InsufficientBalance when the trace is empty.
This patch propagates the insufficient balance error through the rpc stack rather than rewriting it to a generic "other" error type with a custom message.
BFT companion patch: category-labs/monad-bft#3234