feat: replace fzf with skim as the default chooser#2855
Open
bestgopher wants to merge 1 commit intocasey:masterfrom
Open
feat: replace fzf with skim as the default chooser#2855bestgopher wants to merge 1 commit intocasey:masterfrom
bestgopher wants to merge 1 commit intocasey:masterfrom
Conversation
bestgopher
force-pushed
the
choose
branch
2 times, most recently
from
88885fc to
0c74cd6
Compare
Author
|
I don't know how to fix some test case errors. |
Author
|
@casey When you have a chance, could you take a look. |
casey
requested changes
Apr 3, 2026
Owner
casey
left a comment
casey
left a comment
There was a problem hiding this comment.
Sorry for letting this sit. See comments!
| @@ -0,0 +1,127 @@ | |||
| use crate::config::Config; | |||
Owner
There was a problem hiding this comment.
You can use use super::* and get rid of a lot of these imports.
|
|
||
| impl<'a> Chooser<'_, 'a> { | ||
| fn run_with_command(self, recipes: Vec<&Recipe>) -> Result<Vec<String>, Error<'a>> { | ||
| let Self::Command { |
Owner
There was a problem hiding this comment.
I would pass these arguments in instead of taking self.
| Ok(recipes) | ||
| } | ||
|
|
||
| fn run_with_skim(recipes: Vec<&Recipe>) -> Result<Vec<String>, Error<'a>> { |
Owner
There was a problem hiding this comment.
Suggested change
| fn run_with_skim(recipes: Vec<&Recipe>) -> Result<Vec<String>, Error<'a>> { | |
| fn choose_with_skim(recipes: Vec<&Recipe>) -> Result<Vec<String>, Error<'a>> { |
| } | ||
|
|
||
| impl<'a> Chooser<'_, 'a> { | ||
| fn run_with_command(self, recipes: Vec<&Recipe>) -> Result<Vec<String>, Error<'a>> { |
Owner
There was a problem hiding this comment.
Suggested change
| fn run_with_command(self, recipes: Vec<&Recipe>) -> Result<Vec<String>, Error<'a>> { | |
| fn choose_with_command(self, recipes: Vec<&Recipe>) -> Result<Vec<String>, Error<'a>> { |
| let options = SkimOptionsBuilder::default() | ||
| .height(String::from("100%")) | ||
| .multi(true) | ||
| .preview(Some("just --unstable --color always --show {}".to_string())) |
Owner
There was a problem hiding this comment.
I'd like to avoid a recursive call here. Can we pass in both the items and their previews?
|
|
||
| // `run_with` would read and show items from the stream | ||
| let selected_items = | ||
| Skim::run_with(&options, Some(items)).map_or_else(Vec::new, |out| out.selected_items); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #939
2025-08-08.17.20.26.mov