Print executed commands if run in verbose mode#2852
Open
tgross35 wants to merge 1 commit intocasey:masterfrom
Open
Print executed commands if run in verbose mode#2852tgross35 wants to merge 1 commit intocasey:masterfrom
tgross35 wants to merge 1 commit intocasey:masterfrom
Conversation
tgross35
force-pushed
the
verbose-cmd
branch
5 times, most recently
from
37bb91a to
1c227ab
Compare
It is currently difficult to debug what went wrong in cases such as OS
exec errors, because verbose output prints the file but does not say how
it is run. Update spawning to print executed commands with loquacious
and above verbosity. The result when run with `-v` is something like the
following:
+ cd "/home/user/workspace" && "/run/user/1000/just/just-kynaKD/configure"
The `+` syntax is meant to match shell scripts run with `-x`. This gets
coloring to differentiate it.
Environment variables are not printed unless `-vv` is set:
+ cd "/home/user/workspace" && RUST_BACKTRACE="1" CARGO_HOME="/cargo-home" "/run/user/1000/just/just-r2rLtg/configure"
casey
requested changes
Apr 3, 2026
Owner
casey
left a comment
casey
left a comment
There was a problem hiding this comment.
Sorry for letting this sit! I think this is good, but I think that it's noisy enough that it should bet its own flag --trace, and not be part of -v. I would suggest using -vv, but -vv prints scripts, which is very annoying.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is currently difficult to debug what went wrong in cases such as OS exec errors, because verbose output prints the file but does not say how it is run. Update spawning to print executed commands with loquacious and above verbosity. The result when run with
-vis something like the following:The
+syntax is meant to match shell scripts run with-x. This gets coloring to differentiate it.Environment variables are not printed unless
-vvis set: