Compile with JDK8 to allow using the library from java 8 projects#4
Open
rabelenda wants to merge 3 commits intocarlanton:masterfrom
Open
Compile with JDK8 to allow using the library from java 8 projects#4rabelenda wants to merge 3 commits intocarlanton:masterfrom
rabelenda wants to merge 3 commits intocarlanton:masterfrom
Conversation
Owner
|
Hi Roger, Thanks for the PR. Not sure if I want to go back to jdk 8. Why do you want to to this? Also, you can already configure the objectmapper like this: |
Author
|
Hi, thank you for your reply. We want to use this great library from a JMeter plugin, and we don't want to add restrictions to users and enforce them to have to install newer jdks. If you don't want to support jdk8 then we would need to maintain a separate fork for this :-(. Regarding modifying the object mapper from client code, do you think is better doing that from client side? I mean, it seems that the standard specifies that any "unknown" xml attribute or element should be ignored, so I would expect the library to do that by default. Regards |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additionally, upgrade jackson and set
FAIL_ON_UNKNOWN_PROPERTIESproperty tofalseto avoid getting an exception when an unrecognized property is found in mpd (this is the expected behavior according to the iso, and reflected on schema).