Repository navigation
Conversation
Step 6 listed what merge-tracker.mjs does with the files in batch/tracker-additions/ but not what happens when one cannot be read. Since career-ops-hq/career-ops#3706 a malformed addition is skipped with a Skipping warning that names the file and the problem, and no tracker row is added. Say so, and point at --dry-run, which prints the same warnings before anything is archived. EN, ES, FR and DE; translationHash restamped. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@vliggio is attempting to deploy a commit to the Career Ops OSS Program Team on Vercel. A member of the Team first needs to authorize it. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 33 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #91 (which closed #62). That change fixed the description of the addition files; this one covers the other user-visible half of career-ops-hq/career-ops#3706.
What was missing
Step 6 of the batch guide lists what
merge-tracker.mjsdoes with the files inbatch/tracker-additions/(read, dedupe, add, archive) and says nothing about a file it cannot read. Since career-ops-hq/career-ops#3706, a malformed addition is refused: the script prints a⚠️ Skipping <file>: …warning that names the problem and adds no tracker row for that offer. A reader whose batch finished with one row fewer than expected had no line in the guide to explain it.What it says now
One paragraph after the
--dry-runblock in Step 6:Same paragraph in all four copies:
content/docs/introduction/guides/batch-evaluate-offers.mdxcontent/docs/introduction/guides/batch-evaluate-offers.es.mdxcontent/docs/introduction/guides/batch-evaluate-offers.fr.mdxcontent/docs/introduction/guides/batch-evaluate-offers.de.mdxtranslationHashin ES, FR and DE goes fromd7a6ccee0dc73e47toee84e9227a63d238(node .i18n/hash.mjson the English file).Checked against the core
Read from
merge-tracker.mjson career-opsmaintoday, not run:⚠️ Skipping ${filename}: …and return no addition; the merge loop counts the file as skipped and moves on.--dry-runruns the same parse loop, so it prints the same warnings. Only the tracker write and the move tomerged/are gated on it.Validation
npm run types:check: passes.npm run build: passes.scripts/verify-agent-layer.mjsagainst the local build: 1 failure,/changelog.md release headings lost their subject. That route renders from the release listsrc/lib/releasesfetches, and this change touches only four.mdxfiles, so I believe it is the local environment rather than this diff. CI will say..mdtwin of the guide carries the new paragraph in all four languages on the local build.AI assistance
Claude Code (Claude Opus 5.5), in a session started by @vliggio. The ES, FR and DE paragraphs were translated by the agent, not by the
.i18n/translate.mjspipeline.Human review
🤖 Generated with Claude Code