fix: throw BuildError during cds build to terminate build on errors #334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #308 Changes: - Add BuildError import from cds.build in lib/build.js - Wrap build() method in try-catch and throw BuildError on failure - Remove unnecessary inner try-catch blocks in _writeResourcesFiles - Refactor code for better readability (_createProgressBar, _countTotalFiles) - Update unit tests to expect thrown errors instead of silent handling - Add cds build integration tests (cds-build.test.js) - Add @cap-js/ord dependency to integration-test-app for build plugin discovery - Add test:integration:build npm script
![hyperspace-insights[bot]](https://avatars.githubusercontent.com/u/2531208?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
The pull request improves error handling by ensuring build failures terminate the process properly. However, there are three substantive issues: (1) Promise.all may process partial results on early errors, (2) potential TypeError when resourceDefinitions is undefined, and (3) a test that doesn't reflect the actual wrapped error behavior.
PR Bot Information
Version: 1.17.30 | 📖 Documentation | 🚨 Create Incident | 💬 Feedback
- LLM:
anthropic--claude-4.5-sonnet - Correlation ID:
7a7e3950-f7b1-11f0-84c5-e4cc77060242 - Event Trigger:
issue_comment.created
swennemers
reviewed
Jan 22, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #308
This PR ensures that errors during
cds buildproperly terminate the build process by throwing aBuildErrorinstead of silently logging errors.Changes
Core Fix (
lib/build.js)BuildErrorimport fromcds.buildbuild()method in try-catch and throwBuildErroron failure_writeResourcesFiles- let errors bubble up naturally_createProgressBar(),_countTotalFiles()helper methods)Tests
__tests__/unit/build.test.js): Updated to expect thrown errors instead of silent handling__tests__/integration/cds-build.test.js): Added 7 new test casesConfiguration
@cap-js/orddependency to enable build plugin discoverytest:integration:buildnpm scriptTest Results
Design Philosophy
Follows CAP Build Plugin design philosophy:
this.pushMessage(message, severity)- for non-fatal info/warningsthrow new BuildError(message)- for critical errors that should terminate the build