fix: style the baseline grid toggle on standalone examples - #5836
Open
samuelmbabhazi wants to merge 1 commit into
Open
fix: style the baseline grid toggle on standalone examples#5836samuelmbabhazi wants to merge 1 commit into
samuelmbabhazi wants to merge 1 commit into
Conversation
The switch styles were not compiled into the standalone examples stylesheet, so the toggle rendered as a bare checkbox. The switch pattern's disabled-state extend now tolerates contexts that do not compile the base form styles alongside, which is what broke the previous attempt, and the compiled library CSS is unchanged.
|
samuelmbabhazi is not a collaborator of the repo |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done
@extendoptional, so the pattern also compiles in contexts that do not compile the base form styles alongside; the missing%vf-disabled-elementplaceholder is what failed CI on the previous attempt (Fix baseline grid toggle styling on standalone examples #5684)Fixes #5286
QA
/docs/examples/standalone/patterns/buttons/combined?theme=lightyarn build-scss,build/css/docs/example.cssis the only output file whose content changes. Every build that compiles the base form styles still defines the placeholder, so the extend behaves exactly as before thereCheck if PR is ready for release
Bug 🐛label (I cannot set labels on this repository)releases.ymlentry needed