fix: deprecation cleanup and docs update - #5831
Open
gaurav7902 wants to merge 2 commits into
Open
Conversation
|
gaurav7902 is not a collaborator of the repo |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR performs framework SCSS deprecation cleanup and updates logo-block documentation/examples to reflect the deprecation of the dense variant in favor of the default .p-logo-section.
Changes:
- Removed example-only grid demo styles from legacy grid pattern mixins.
- Removed unused/deprecated SCSS settings variables and adjusted settings comments.
- Updated logo-block docs and the “dense” example to use
.p-logo-sectioninstead of.p-logo-section--dense.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| templates/docs/patterns/logo-block/index.md | Updates dense-variant guidance and example link text for logo-block docs. |
| templates/docs/examples/patterns/logo-block/logo-block-dense.html | Updates dense example markup to use .p-logo-section and adjusts example titling clarity. |
| scss/_settings_placeholders.scss | Deprecation cleanup around placeholder settings (notably $border-radius). |
| scss/_settings_font.scss | Removes unused font weight variable and updates nearby comment. |
| scss/_patterns_grid.scss | Removes .grid-demo styling and updates mixin comment/indentation for clarity. |
| scss/_patterns_grid-8.scss | Removes .grid-demo styling and updates mixin comment to avoid stale FIXME. |
Suppressed comments (1)
templates/docs/patterns/logo-block/index.md:46
- This section now says to use
.p-logo-section(default) but the example link text still says it’s a “dense logo block” example, which is confusing since the dense variant is deprecated and the linked example template was updated to use the default class.
Use `.p-logo-section` to display logos in a compact layout.
<div class="embedded-example"><a href="/docs/examples/patterns/logo-block/logo-block-dense/" class="js-example">
View example of the dense logo block
</a></div>
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done
.grid-demostyles fromscss/_patterns_grid.scssandscss/_patterns_grid-8.scss(kept maintainer FIXME comments).$font-weight-thinvariable fromscss/_settings_font.scss(kept maintainer TODO comment).$border-radiusvariable fromscss/_settings_placeholders.scss(kept deprecation notice).templates/docs/patterns/logo-block/index.mdandtemplates/docs/examples/patterns/logo-block/logo-block-dense.htmlto use.p-logo-sectioninstead of.p-logo-section--dense.Fixes: General technical debt cleanup and documentation updates.
QA
Check if PR is ready for release
Maintenance 🔨package.jsonshould be updated relative to the most recent release, following semver conventionScreenshots
N/A - Internal cleanup and documentation update.