Skip to content

fix: deprecation cleanup and docs update - #5831

Open
gaurav7902 wants to merge 2 commits into
canonical:mainfrom
gaurav7902:main
Open

fix: deprecation cleanup and docs update#5831
gaurav7902 wants to merge 2 commits into
canonical:mainfrom
gaurav7902:main

Conversation

@gaurav7902

Copy link
Copy Markdown

Done

  • Framework Cleanup (SCSS)
    • Removed .grid-demo styles from scss/_patterns_grid.scss and scss/_patterns_grid-8.scss (kept maintainer FIXME comments).
    • Removed unused $font-weight-thin variable from scss/_settings_font.scss (kept maintainer TODO comment).
    • Removed deprecated $border-radius variable from scss/_settings_placeholders.scss (kept deprecation notice).
  • Documentation and Example Updates
    • Updated templates/docs/patterns/logo-block/index.md and templates/docs/examples/patterns/logo-block/logo-block-dense.html to use .p-logo-section instead of .p-logo-section--dense.

Fixes: General technical debt cleanup and documentation updates.

QA

  • Verified SCSS compiles without errors.
  • Verified that removed styles and variables do not impact production styles.
  • Reviewed updated documentation for logo-block.

Check if PR is ready for release

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Maintenance 🔨
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention
  • Any changes to component class names (new patterns, variants, removed or added features) or macros should be listed on the what's new page.

Screenshots

N/A - Internal cleanup and documentation update.

Copilot AI lite review requested due to automatic review settings August 18, 2026 19:19
@webteam-app

Copy link
Copy Markdown

gaurav7902 is not a collaborator of the repo

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR performs framework SCSS deprecation cleanup and updates logo-block documentation/examples to reflect the deprecation of the dense variant in favor of the default .p-logo-section.

Changes:

  • Removed example-only grid demo styles from legacy grid pattern mixins.
  • Removed unused/deprecated SCSS settings variables and adjusted settings comments.
  • Updated logo-block docs and the “dense” example to use .p-logo-section instead of .p-logo-section--dense.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
templates/docs/patterns/logo-block/index.md Updates dense-variant guidance and example link text for logo-block docs.
templates/docs/examples/patterns/logo-block/logo-block-dense.html Updates dense example markup to use .p-logo-section and adjusts example titling clarity.
scss/_settings_placeholders.scss Deprecation cleanup around placeholder settings (notably $border-radius).
scss/_settings_font.scss Removes unused font weight variable and updates nearby comment.
scss/_patterns_grid.scss Removes .grid-demo styling and updates mixin comment/indentation for clarity.
scss/_patterns_grid-8.scss Removes .grid-demo styling and updates mixin comment to avoid stale FIXME.
Suppressed comments (1)

templates/docs/patterns/logo-block/index.md:46

  • This section now says to use .p-logo-section (default) but the example link text still says it’s a “dense logo block” example, which is confusing since the dense variant is deprecated and the linked example template was updated to use the default class.
Use `.p-logo-section` to display logos in a compact layout.

<div class="embedded-example"><a href="/docs/examples/patterns/logo-block/logo-block-dense/" class="js-example">
View example of the dense logo block
</a></div>

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread scss/_settings_placeholders.scss Outdated
Comment thread templates/docs/examples/patterns/logo-block/logo-block-dense.html
Comment thread scss/_settings_font.scss
Comment thread scss/_patterns_grid.scss
Comment thread scss/_patterns_grid-8.scss
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants