feat(WD-37393): Product card pattern - #5821
Conversation
|
Thanks so much @muhammad-ali-pk! The animation and card interaction itself LGTM! Just had a couple other qs - Where will this live within Vanilla documentation? I can't seem to find it in the side navigation. Additionally, the card should only occupy 2 columns. Could we see what the card looks like on the article page to see how it resizes and behaves on the page? Also there are quite a few copy updates that need to be made to the card content. Is there a separate PR for this or will it be handled here too? |
|
Thank you @muhammad-ali-pk ! The design LGTM :) No comments in addition to Elaine's |
It should live under "patterns" now in the side nav.
Sure, I set up a demo here
This PR only handles upstreaming product card pattern to vanilla repo. The card content still lives on relevant repos (canonical/ubuntu) and should be updated there. |
Done
Fixes WD-37393
QA
Check if PR is ready for release
If this PR contains Vanilla SCSS or macro code changes, it should contain the following changes to make sure it's ready for the release:
Feature 🎁,Breaking Change 💣,Bug 🐛,Documentation 📝,Maintenance 🔨.package.jsonshould be updated relative to the most recent release, following semver conventionScreenshots
[if relevant, include a screenshot or screen capture]