Simplify pagination item margin CSS

[Ataku-B]

Done

• Simplified pagination items' margin assignment. This fixes uneven margins that occur when leading pagination items are hidden for any reason (e.g. reducing the number of pages shown on small screens)

QA

Open the demos and check the spacing between pagination items:

• Pagination / Deprecated
• Pagination / Disabled
• Pagination / Truncated
• Pagination / Previous and next buttons only
• Pagination / Default

Check if PR is ready for release

If this PR contains Vanilla SCSS or macro code changes, it should contain the following changes to make sure it's ready for the release:

• PR should have one of the following labels to automatically categorise it in release notes:
  • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
• Vanilla version in package.json should be updated relative to the most recent release, following semver convention
  • if existing APIs (CSS classes & macro APIs) are not changed it can be a bugfix release (x.x.X)
  • if existing APIs (CSS classes & macro APIs) are changed/added/removed it should be a minor version (x.X.0)
  • see the wiki for more details
• Any changes to component class names (new patterns, variants, removed or added features) or macros should be listed on the what's new page.

[webteam-app]

Demo

Jenkins

demos.haus

[immortalcodes]

Hey Atakan,
Could you please remove this line

vanilla-framework/scss/_patterns_content-card.scss

Line 566 in a7c1a43

padding-bottom: 0;

as part of this PR.
It mistakenly got slipped in the previous PR during linting and is causes spacing issues.
The issue it is causing is no padding at bottom of 8-col-card

Thanks

[immortalcodes]

Shall we ask for design review on this? What do you think?

[Ataku-B]

@immortalcodes Hi Madhur, I've removed that line, the padding seems to be okay now. As for the design review, I am not sure. The point of this change is for the existing pagination items to look visually identical. We can add a new example page demonstrating the ability to hide some pagination items on small screens, which I think would definitely warrant a design review. What do you think?

[Skazitron]

Would this introduce bugs in existing layouts? Maybe we could demo it in a test file?

[Skazitron]

@Ataku-B Left some comments.

[Skazitron]

Can you please add this to releases.yaml as well?

[Ataku-B]

releases.yaml currently lists 4.53.0 as the lastest release, being the 8-col-card release, it seems package.json wasn't updated for it. This being a minor bump, I will update package.json to show 4.53.1, is that okay?

[immortalcodes]

@immortalcodes Hi Madhur, I've removed that line, the padding seems to be okay now. As for the design review, I am not sure. The point of this change is for the existing pagination items to look visually identical. We can add a new example page demonstrating the ability to hide some pagination items on small screens, which I think would definitely warrant a design review. What do you think?

Looking at code, I understand it is just to maintain uniformity so I don't think we need design.
Thanks

[diana-stanciulescu]

@Ataku-B hi, can you please update the ticket with the scope and current status so we can make a decision? can;t access the demos anymore and uncler on pagination vs. cards conversation. thanks!