Repository navigation
Conversation
Signed-off-by: mr-cal-bot <callahanlovesshopping@gmail.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| - name: Upload test results | ||
| if: always() | ||
| uses: actions/upload-artifact@v7 |
|
|
||
| - name: Upload test results | ||
| if: always() | ||
| uses: actions/upload-artifact@v7 |
|
|
||
| - name: Upload test results | ||
| if: always() | ||
| uses: actions/upload-artifact@v7 |
|
|
||
| - name: Upload test results | ||
| if: always() | ||
| uses: actions/upload-artifact@v7 |
|
|
||
| - name: Upload test results | ||
| if: always() | ||
| uses: actions/upload-artifact@v7 |
|
|
||
| - name: Upload test results | ||
| if: always() | ||
| uses: actions/upload-artifact@v7 |
|
|
||
| - name: Upload test results | ||
| if: always() | ||
| uses: actions/upload-artifact@v7 |
|
|
||
| - name: Upload test results | ||
| if: always() | ||
| uses: actions/upload-artifact@v7 |
|
|
||
| - name: Upload test results | ||
| if: always() && steps.decisions.outputs.RUN == 'true' | ||
| uses: actions/upload-artifact@v7 |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
An active moderate issue remains because the artifact name contains colons that actions/upload-artifact rejects, causing JUnit uploads to fail for integration matrix jobs.
1 open issue
What changed in this PR
This pull request updates Spread CI workflows to exercise Starflow’s experimental run-spread action and publish JUnit XML results as artifacts.
Changes:
- Replaces direct
spreadinvocations in integration and manual workflows withcanonical/starflow/run-spread@work/junit-for-spread. - Adds unique JUnit names and
always()artifact-upload steps. - Separates Ubuntu Pro token validation from the Pro Spread action invocation.
| File | Summary |
|---|---|
.github/workflows/spread.yml |
Converts integration and store Spread jobs to the Starflow action and adds JUnit artifact uploads. Moderate finding (3 votes): artifact names derived from matrix.spread-jobs contain :, which actions/upload-artifact rejects. |
.github/workflows/spread-manual.yaml |
Converts seven manual Spread jobs and adds per-job JUnit artifact uploads. |
Review effort: Lite
| if: always() | ||
| uses: actions/upload-artifact@v7 | ||
| with: | ||
| name: test-results-${{ matrix.spread-jobs }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test PR for the new run-spread action in starflow (branch
work/junit-for-spread), which runs spread and publishes the results as JUnit XML artifacts.Changes
canonical/starflow/run-spread@work/junit-for-spreadinstead of callingspreaddirectly. The Ubuntu Pro token check is split into its own gating step so the action step stays declarative.junit-name.if: always()artifact upload ofresults/junit*.xml.spread openstack:...docs...invocation is a placeholder.What to look for
test-results-*) attached to failed and successful runs.-----error block as failure text.spread -list.spread -listfailures degrade to a warning, not a job failure.Do not merge: this exists to exercise the action against real spread workflows. Once the starflow side lands, re-pin to
canonical/starflow/run-spread@mainor close.