Skip to content

fix(kernel): set CONFIG_VERSION_SIGNATURE for Ubuntu flavour configs (#6497) #6542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
canonical-nicoharnois wants to merge 1 commit into
base: hotfix/9.2
Choose a base branch
from
+20 −0
Open

fix(kernel): set CONFIG_VERSION_SIGNATURE for Ubuntu flavour configs (#6497) #6542

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions docs/reference/plugins/kernel_plugin.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,12 @@ variants can be found `here <https://ubuntu.com/kernel/variants>`_, but valid
choices will depend on the chosen kernel source. If something other than
``generic`` is provided, this value takes precedence over the ``kernel-kdefconfig`` key.

When the configuration is generated from an Ubuntu kernel flavour, the plugin sets
``CONFIG_VERSION_SIGNATURE`` the same way the Ubuntu kernel packages do, for example
``Ubuntu 6.8.0-1012.12-mtk 6.8.12``. This populates ``/proc/version_signature`` on the
built kernel. To use a different value, set ``CONFIG_VERSION_SIGNATURE`` in the
``kernel-kconfigs`` key.


kernel-ubuntu-release-name
~~~~~~~~~~~~~~~~~~~~~~~~~~
Expand Down
8 changes: 8 additions & 0 deletions docs/release-notes/snapcraft-9-2.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,14 @@ Snapcraft 9.2.1
- `snapcraft#6336 <https://github.com/canonical/snapcraft/issues/6336>`__ Snapcraft 9:
snapcraftctl errors in core22 snaps

.. _release-notes-fixes-9.2.2:

Snapcraft 9.2.2
~~~~~~~~~~~~~~~

- `snapcraft#6497 <https://github.com/canonical/snapcraft/issues/6497>`__ Kernel plugin
leaves ``/proc/version_signature`` empty


Contributors
------------
Expand Down
6 changes: 6 additions & 0 deletions snapcraft/parts/plugins/kernel_build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,12 @@ gen_flavour_config() {
rm -rf CONFIGS

cd "${OLDPWD}"

# Set CONFIG_VERSION_SIGNATURE as debian/rules does, since genconfigs leaves it empty
release_info
_kernelversion="$(make -s --no-print-directory -C "${KERNEL_SRC}" kernelversion)"
sed -i "s/.*CONFIG_VERSION_SIGNATURE.*/CONFIG_VERSION_SIGNATURE=\"Ubuntu ${release}-${revision}-${_kconfigflavour} ${_kernelversion}\"/" \
"${CRAFT_PART_BUILD}/.config"
}

# add_kconfigs adds any specified config options
Expand Down
Loading