Repository navigation
Conversation
Points the lint job at `canonical/starflow/.github/workflows/lint-python.yaml@work/separate-linkcheck` to exercise the lint workflow being reworked in canonical/starflow#199. That change splits the lint workflow into separate jobs and renames the `lint` make target to `lint-code`. Alongside the workflow reference, this splits the aggregate `lint` target so the code linters can be addressed as `lint-code`, matching the repositories that already provide it. `lint` still runs everything for local use. `docs-lint` and the `docs-%` passthrough that supplies `docs-linkcheck` already exist here, so no other make target is needed.
| - '!({docs/**,*.md,**/*.md,.readthedocs.yaml})' | ||
| lint: | ||
| uses: canonical/starflow/.github/workflows/lint-python.yaml@main | ||
| uses: canonical/starflow/.github/workflows/lint-python.yaml@work/separate-linkcheck |
There was a problem hiding this comment.
🟡 Changes recommended
Documentation changes would run link checking twice, and a link failure would still fail the docs job.
1 open finding
What changed in this PR
This PR tests the split Starflow lint workflow in this repository ahead of canonical/starflow#199.
Changes:
- Points CI at the workflow’s test branch.
- Adds
lint-codewhile keeping an aggregatelinttarget.
| File | Description |
|---|---|
| Makefile | Adds the code-only lint target and updates aggregate lint. |
| .github/workflows/qa.yaml | Uses the split workflow’s test branch. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| .PHONY: lint | ||
| lint: lint-ruff lint-ty lint-codespell lint-prettier lint-shellcheck lint-docs lint-twine lint-uv-lockfile ## Run all linters | ||
| lint: lint-code lint-docs lint-twine lint-uv-lockfile ## Run all linters |
|
Status of this integration test for canonical/starflow#199 is recorded in a table in that pull request. The These come from the Reported files, none of them modified here: |
|
Closing: integration test of canonical/starflow#199 complete. Results recorded in canonical/starflow#199. |

Summary
Points the lint job at
canonical/starflow/.github/workflows/lint-python.yaml@work/separate-linkcheckto exercise the lint workflow that is being reworked in canonical/starflow#199.That change splits the lint workflow into separate jobs and renames the
lintmake target tolint-code:filterfilesmake -k lint-codedocsmake -k docs-lintlinkcheckmake -k docs-linkcheckThis repository had no
lint-codetarget, so the aggregatelinttarget is split to match the repositories that already provide it.lintstill runs everything for local use.Scope
Workflow reference and
Makefileonly. No source changes.The
docsandlinkcheckjobs are expected to be skipped on this pull request, because it touches no documentation. They are exercised by pull requests that changedocs/, Markdown, or reStructuredText files.Relationship to canonical/starflow#199
This pull request is an integration test for canonical/starflow#199. It should not be merged before that one lands, and the reference should be moved back to
mainafterwards.Each repository that is testing this branch is listed in the table on canonical/starflow#199.