Skip to content

fix: add nosec annotations for bandit HIGH findings #5452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
louiseschmidtgen wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: add nosec annotations for bandit HIGH findings #5452

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ec285e
fix: add nosec annotations for bandit HIGH findings
louiseschmidtgen Apr 9, 2026
625d21b
fix: format nosec annotations to satisfy black
louiseschmidtgen Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions scripts/wrappers/distributed_op.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ def do_configure_op(remote_op):
res = requests.post(
"https://{}/{}/configure".format(node_ep, CLUSTER_API_V1),
json=remote_op,
verify=False,
verify=False, # nosec B501
)
if res.status_code != 200:
print(
Expand Down Expand Up @@ -141,7 +141,7 @@ def do_image_import(image_data):
headers={
"x-microk8s-callback-token": token,
},
verify=False,
verify=False, # nosec B501
)

if res.status_code != 200:
Expand Down
4 changes: 2 additions & 2 deletions scripts/wrappers/join.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ def get_etcd_client_cert(master_ip, master_port, token):
signed = requests.post(
"https://{}:{}/{}/sign-cert".format(master_ip, master_port, CLUSTER_API),
json=req_data,
verify=False,
verify=False, # nosec B501
)
if signed.status_code != 200:
print("Failed to sign certificate. {}".format(signed.json()["error"]))
Expand Down Expand Up @@ -250,7 +250,7 @@ def get_client_cert(master_ip, master_port, fname: str, token: str, subject: str
signed = requests.post(
"https://{}:{}/{}/sign-cert".format(master_ip, master_port, CLUSTER_API),
json=req_data,
verify=False,
verify=False, # nosec B501
)
if signed.status_code != 200:
error = "Failed to sign {} certificate ({}).".format(fname, signed.status_code)
Expand Down
4 changes: 3 additions & 1 deletion scripts/wrappers/upgrade.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,9 @@ def node_upgrade(upgrade, phase, node_ep, token):
remote_op = {"callback": token, "phase": phase, "upgrade": upgrade}
# TODO: handle ssl verification
res = requests.post(
"https://{}/{}/upgrade".format(node_ep, CLUSTER_API), json=remote_op, verify=False
"https://{}/{}/upgrade".format(node_ep, CLUSTER_API),
json=remote_op,
verify=False, # nosec B501
)
if res.status_code != 200:
print("Failed to perform a {} on node {}".format(remote_op["upgrade"], node_ep))
Expand Down
5 changes: 4 additions & 1 deletion tests/test-cluster.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,10 @@ def run(self, cmd):
elif self.backend == "lxc":
cmd_prefix = "/snap/bin/lxc exec {} -- ".format(self.vm_name)
with subprocess.Popen(
cmd_prefix + cmd, shell=True, stdout=subprocess.PIPE, preexec_fn=os.setsid
cmd_prefix + cmd,
shell=True,
stdout=subprocess.PIPE,
preexec_fn=os.setsid, # nosec B602
) as process:
try:
output = process.communicate(timeout=300)[0]
Expand Down
Loading