Skip to content

✨ Quality: shutil.which() return value not checked before os.path.dirname() #5413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Manhhoangvp95 wants to merge 2 commits into
base: master
Choose a base branch
from
+4 −0
Open

✨ Quality: shutil.which() return value not checked before os.path.dirname() #5413

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
37072e1
refactor: shutil.which() return value not checked before os.path.dirn…
Manhhoangvp95 Mar 27, 2026
dffa233
Update installer/common/file_utils.py
Manhhoangvp95 May 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions installer/common/file_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,10 @@ def get_kubectl_directory() -> str:
return os.path.join(d, "kubectl")
else:
full_path = shutil.which("kubectl")
if full_path is None:
raise FileNotFoundError(
"kubectl not found in PATH. Please install kubectl or ensure it is available on your system PATH."
)
return os.path.dirname(full_path)


Expand Down