fix: correct local query and curate messaging#668
Open
strasserwm wants to merge 5 commits into
Open
Conversation
Collaborator
|
Hey @strasserwm could you merge main into this branch when you get a chance? There've been a few updates upstream, and syncing will keep CI green and make review easier. Thanks! |
…ry-curate-fixes-verify # Conflicts: # src/oclif/commands/query.ts
Author
|
Merged latest main and pushed fixes for the post-merge CI regressions. The
latest commit is 8418a82. Validation is
currently skipped because safe-to-test was removed after the push. Could
you please re-add safe-to-test when you get a chance?
…On Wed, May 20, 2026 at 12:30 AM bao-byterover ***@***.***> wrote:
*bao-byterover* left a comment (campfirein/byterover-cli#668)
<#668 (comment)>
Hey @strasserwm <https://github.com/strasserwm> could you merge main into
this branch when you get a chance? There've been a few updates upstream,
and syncing will keep CI green and make review easier. Thanks!
—
Reply to this email directly, view it on GitHub
<#668 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI2JSSZZEYSVIF424322XBD43UYGDAVCNFSM6AAAAACZBVYKKSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DIOJUGUZDIMJQGY>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two local ByteRover query/curate UX issues:
401/Unauthorizedfailures were shown as cloud-sync login failures, telling users to runbrv logineven when local query/curate only needed provider credentials.brv curatecould printContext curated successfullyfor blocked/no-op curation responses where no context-tree operations were applied.Changes
brv loginguidance for true ByteRover cloud auth /NOT_AUTHENTICATEDcases.error.No context changes appliedfor genuine successful no-op curation.Verification
Performed locally:
git apply --checkfor Phase 1 patchgit apply --checkfor Phase 2 patchgit apply --checkfor combined patchgit diff --check9 passingCould not fully verify locally because this checkout lacks private/incomplete dependencies:
mochais missing locallynpm install/ full dependency repair is blocked by privategithub.com/campfirein/byterover-packagestsc --noEmitreports repo-wide missing dependency/type errors unrelated to this patch setRecommended maintainer verification with private deps available:
Risk notes