Allow the user to configure the location of the mdbase type definitions#1775
Allow the user to configure the location of the mdbase type definitions#1775aldrichtr wants to merge 5 commits into
Conversation
- Added `userMdbaseSpecLocation` to the settings; A vault-local path to
the types folder.
- Added new private variables to represent mdbase configuration paths:
- `_default_types_folder` default folder if userMdbaseSpecLocation is not
defined.
- `_defaultMdbConfigFile` default mdb configuration file (`mdbase.yaml`)
This should not change, unless mdbase/mdbase-cli gains a configurable path
for this file.
- `_defaultTaskDefinitionFile` default file where task schema is defined.
- Added private method to retrieve the path from settings or fall-back to
default.
|
Just wanted to say thank you to the maintainers of this amazing plugin! I kept the changes as small as possible per commit so that it was obvious what was being changed. If you would like they can be rebased to just two. The settings and service changes; and the ui changes. Happy to modify in whatever way you want in order to fit in with your coding standards and build chain. |
|
This change requires further testing. Although the above manual tests are successful, the original |
|
Thanks again for working through this and for documenting the manual testing. I think we should close this PR rather than merge it as-is because the current local fix takes a smaller route: TaskNotes now preserves an existing I have credited this PR's implementation exploration in the unreleased notes alongside #1853. |
Overview of changes
settings.userMdbaseSpecLocationItems remaining to be verified or completed:
enbut I don't know how to test that the translations are accurate either.
_types.Manual testing
After running
npm run build:test:tasknotes-e2e-vault. I opened the settings for the tasknotes plugin and confirmed that the new field is presented to the user, and that the user is able to add a path:closes: #1757