Skip to content

auto deploy gtfs-rt archiver only on staging/official branch - #5673

Open
tihuang02 wants to merge 6 commits into
mainfrom
5664-dedicated-staging
Open

tihuang02 wants to merge 6 commits into
mainfrom
5664-dedicated-staging

Conversation

@tihuang02

@tihuang02 tihuang02 commented Aug 21, 2026 •

Copy link
Copy Markdown
Contributor

Description

auto deploy gtfs-rt archiver only on staging/official branch

Resolve #5664

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

How has this been tested?

not tested as no way to test github actions

Post-merge follow-ups

  • No action required
  • Actions required (specified below)

Fake a gtfs-rt archiver change to test the github action.

@vevetron
vevetron force-pushed the 5664-dedicated-staging branch from f9743c3 to ce16510 Compare September 3, 2026 20:33

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should line 12 be renamed if the whole file is renamed?

@fsalemi

fsalemi commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

@tihuang02, Question1:

  1. staging plans may no longer run for IaC PRs targeting main.
    The issue Proposal: Dedicated staging branch to test code #5664 mentions that infra changes under iac/cal-itp-data-infra-staging should continue to be raised against main. With this condition, wouldn't the staging Terraform plan be skipped for those PRs since github.base_ref would be main? Do we want to restrict only the staging apply to staging/official while still allowing staging plans for IaC PRs against main?

@fsalemi

fsalemi commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

@tihuang02, Question2:

  1. pytest may no longer run on feature PRs before merge.
    It looks like the previous gtfs-rt-archiver.yml ran pytest on PRs that changed services/gtfs-rt-archiver/**, while the new test workflow only runs on pushes to main or staging/official. Is removing the PR-level test trigger intentional, or should we keep running these tests on relevant PRs as well?

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Proposal: Dedicated staging branch to test code

3 participants