Simplify test case for TypeHintSniff#355
Merged
Merged
Conversation
othercorey
force-pushed
the
cleanup-tests
branch
4 times, most recently
from
e4fa18c to
33a790e
Compare
othercorey
commented
Feb 21, 2022
| '\\Traversable', | ||
| '\\Stringable', | ||
| '\\Generator', | ||
| '\\Countable', |
Contributor
Author
There was a problem hiding this comment.
This adds Countable. Hard to read with the sort fix.
othercorey
force-pushed
the
cleanup-tests
branch
2 times, most recently
from
6f04744 to
ef4682c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce the number of tests and make them more specific. Easier to read than the random set of types.