Skip to content

Remove parenthesis next to commas#352

Merged
othercorey merged 1 commit into
5.xfrom
complex-arrays
Dec 21, 2021
Merged

Remove parenthesis next to commas#352
othercorey merged 1 commit into
5.xfrom
complex-arrays

Conversation

@othercorey

Copy link
Copy Markdown
Contributor

Fixes #351

@othercorey othercorey added this to the 5.0 milestone Dec 21, 2021
@othercorey othercorey merged commit 10ab122 into 5.x Dec 21, 2021
@othercorey othercorey deleted the complex-arrays branch December 21, 2021 05:10
/** @psalm-var null|scalar|class-string<\Cake\I18n\Number>|array $testVar2 */
$testVar2;

/** @var string|null|array<string|int, array<mixed, array<string>|string|null>|string|null>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be missing closing tag though

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's impossible to read, but after breaking it down manually, it should be right.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean the closing tag of */
For the comment to be valid docblock

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yea! good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants