Skip to content

Add support for scalar type #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
othercorey merged 1 commit into from
Oct 22, 2021
Merged

Add support for scalar type #345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CakePHP/Sniffs/Commenting/TypeHintSniff.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,7 @@ protected function getSortedTypeHint(array $types): string
'callable-string',
'class-string',
'interface-string',
'scalar',
'string',
'float',
'int',
Expand Down
2 changes: 1 addition & 1 deletion CakePHP/Tests/Commenting/TypeHintUnitTest.1.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,6 @@ function test()
/** @var class-string<\Cake\I18n\Number>|null */
$testVar;

/** @psalm-var null|string|class-string<\Cake\I18n\Number>|array $testVar2 */
/** @psalm-var null|scalar|class-string<\Cake\I18n\Number>|array $testVar2 */
$testVar2;
}
2 changes: 1 addition & 1 deletion CakePHP/Tests/Commenting/TypeHintUnitTest.1.inc.fixed
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,6 @@ function test()
/** @var class-string<\Cake\I18n\Number>|null */
$testVar;

/** @psalm-var array|class-string<\Cake\I18n\Number>|string|null $testVar2 */
/** @psalm-var array|class-string<\Cake\I18n\Number>|scalar|null $testVar2 */
$testVar2;
}