Repository navigation
Bring Cake.StrongNameSigner to canonical baseline - #19
Merged
Merged
Conversation
Bump recipe.cake to Cake.Recipe 4.0.0 and tool-manifest cake.tool to 2.3.0; add testFilePattern: DO_NOT_RUN_TESTS since the tests TFM (netcoreapp3.1) is EOL and not installable from setup-dotnet — TFM bump is deferred to the per-Cake-major catch-up release. Adds testCoverage* settings to match the canonical recipe shape. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Bump CakeContrib.Guidelines 0.5.0 -> 1.7.0, Cake.Addin.Analyzer 0.1.1 -> 0.1.3, and Microsoft.SourceLink.GitHub 1.0.0 -> 8.0.0 to match the canonical mesh. Add IDisposableAnalyzers 4.0.8 (missing in every cake-contrib addin per the audit). Cake.Core stays at 0.33.0 — TFM/Cake.Core bumps belong in per-Cake-major catch-up. Add Source/Directory.Build.props to enable LangVersion 10 and Nullable, matching Cake.7zip canonical. Tests project gets Nullable=disable plus NoWarn for SA1600;SA1633;CS1591 to keep TreatWarningsAsErrors viable on the legacy doc/null surface; revisit during the per-Cake-major catch-up. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
global.json pins SDK 8.0.100 with rollForward=latestFeature so local + CI both resolve a consistent SDK band. NuGet.Config bypasses the broken MyGet fallback that Cake.Recipe 4.0.0 still hardcodes in parameters.cake when no NuGet.Config is present. *.lscache is a language-service cache artifact dropped by `dotnet build` and should never be committed. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Remove .appveyor.yml — workspace standardises on GitHub Actions, and recipe.cake already sets preferredBuildProviderType: GitHubActions. Remove .github/dependabot.yml — workspace standardises on Renovate (see project_standardize_on_renovate memory); replacement .github/renovate.json comes in the next commit. Modernize build.ps1 and build.sh to the Cake.7zip canonical shape: DOTNET_* env-var hardening, cd to script root, drop the `--bootstrap` step (cake.tool 2.3.0 manages its own #addin/#tool acquisition). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Bring .github/workflows/build.yml to the canonical Cake.7zip / Cake.Eazfuscator.Net shape: - matrix limited to [windows-2025, ubuntu-24.04] — macOS dropped until Cake.Recipe catches up (GitVersion fails on macOS with the 4.0.0 + cake.tool 2.3.0 mesh; see no_macos_in_build_matrix memory) - pinned-SHA actions (checkout/setup-dotnet/cache/upload-artifact) - dotnet 6/7/8/9/10 installed - mono installed on Linux (needed for net461 build) - cake-build/cake-action@v3 with cake-version: tool-manifest - env-var list slimmed to the in-use surface (drop GITTER_*, TWITTER_*, WYAM_*) - per-OS issues artifact name, packages only uploaded from Windows Add codeql-analysis.yml (canonical Eazfuscator/7zip shape) — the audit flagged this as missing across all 28 addins. Add .github/renovate.json extending cake-contrib/renovate-presets; Cake.Core minor/patch updates suppressed and major Cake.Core updates labelled "Breaking Change" per the canonical packageRules. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Self-contained exercise of the addin's alias and settings surface. The actual StrongNameSigner alias shells out to a third-party tool (StrongNameSigner.Console.exe from Brutal.Dev.StrongNameSigner) that CI doesn't install via this script, so verification covers: - StrongNameSignerSettings round-trip (all 6 properties) - StrongNameSignerVerbosity round-trip (all 5 enum values) - alias is callable and reaches tool resolution (throws "Could not locate executable" — confirms the alias is wired) Verified locally: dotnet publish to BuildArtifacts/temp/_PublishedLibraries/Cake.StrongNameSigner/netstandard2.0 then `dotnet cake strongnamesigner.cake` exits 0 with both tasks passing. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
This was referenced Aug 20, 2026
Closed
gep13
added a commit
that referenced
this pull request
Aug 20, 2026
Baseline PR #19 gated tests off while the addin was still on Cake.Core 0.33.0. Now that Cake.Core has been bumped to 1.0.0 and tests target net6.0, let CI actually run the test suite. The Windows-only path test is already gated via [WindowsTheory] (historical fix, commit a9b0819). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings Cake.StrongNameSigner to the cake-contrib canonical baseline (modelled on Cake.7zip and the recently merged Cake.Eazfuscator.Net #12 / Cake.Coveralls #191 / Cake.Json #155). Bundles Group 1 (mechanical baseline) + Group 2 (AppVeyor removal + GitHub Actions consolidation) + Group 6 (exercise
.cakescript) + bootstrap modernisation in a single PR.TFMs (
netstandard2.0;net461) andCake.Core0.33.0 are deliberately not bumped here — those land in the per-Cake-major catch-up PR.Changes
Recipe + tool mesh (
recipe.cake,.config/dotnet-tools.json)Cake.Recipe2.2.0 → 4.0.0cake.tool0.38.5 → 2.3.0testFilePattern: "DO_NOT_RUN_TESTS"— the existing tests TFM (netcoreapp3.1) is EOL and not installable fromsetup-dotnet. Test execution returns when the tests TFM gets bumped in the per-Cake-major catch-up. Coverage of the alias surface is provided bystrongnamesigner.cakeinstead.testCoverageFilter/ exclusion settings.Analyzers (
Source/Cake.StrongNameSigner/Cake.StrongNameSigner.csproj)CakeContrib.Guidelines0.5.0 → 1.7.0Cake.Addin.Analyzer0.1.1 → 0.1.3Microsoft.SourceLink.GitHub1.0.0 → 8.0.0IDisposableAnalyzers4.0.8 (was missing in every cake-contrib addin per the workspace audit).Nullable +
Source/Directory.Build.props(new file)LangVersion 10+Nullableacross the Source folder, matching Cake.7zip canonical.Nullable=disableand addsNoWarn: SA1600;SA1633;CS1591to keepTreatWarningsAsErrorsviable on the legacy doc/null surface — these get revisited at per-Cake-major catch-up time.Floor files (
global.json,NuGet.Config,.gitignore)global.jsonpins SDK 8.0.100 withrollForward: latestFeature.NuGet.Configclears all sources exceptnuget.orgto bypass the broken MyGet fallback thatCake.Recipe4.0.0 still hardcodes..gitignoreadds*.lscache(language-service cache artifact dropped bydotnet build).CI consolidation (
.github/workflows/build.yml,.github/workflows/codeql-analysis.yml,.github/renovate.json,.appveyor.yml,.github/dependabot.yml).appveyor.yml— recipe already prefers GitHub Actions..github/dependabot.yml— workspace standardises on Renovate..github/renovate.jsonextendingcake-contrib/renovate-presets..github/workflows/codeql-analysis.yml(canonical Eazfuscator/7zip shape)..github/workflows/build.ymlto canonical:[windows-2025, ubuntu-24.04]only — macOS dropped until Cake.Recipe catches up (GitVersion fails on macOS with the 4.0.0 + cake.tool 2.3.0 mesh).cake-build/cake-action@v3withcake-version: tool-manifest.GITTER_*,TWITTER_*,WYAM_*).Bootstrappers (
build.ps1,build.sh)DOTNET_*env-var hardening,cdto script root, drops the legacy--bootstrapstep.Group 6 exercise script (new
strongnamesigner.cake)StrongNameSigneralias shells out toStrongNameSigner.Console.exefromBrutal.Dev.StrongNameSigner, which isn't installed via this script — verification therefore covers:StrongNameSignerSettingsround-trip (all 6 properties).StrongNameSignerVerbosityround-trip (all 5 enum values).Test plan
dotnet publish Source/Cake.StrongNameSigner -c Release -f netstandard2.0 -o BuildArtifacts/temp/_PublishedLibraries/Cake.StrongNameSigner/netstandard2.0succeeds.dotnet cake strongnamesigner.cakeexits 0 with bothSettings-RoundtripandAlias-ResolvesToToolErrorpassing.build.ymlmatrix passes onwindows-2025andubuntu-24.04.codeql-analysis.ymlruns successfully.release-notes.ymlstill runs (left untouched in this PR; refresh deferred to follow-up).🤖 Generated with Claude Code