Conversation
…ice, and logger interfaces with detailed documentation
…max_routes, add ITimeStampProvider interface, and enhance logger with timestamp provider integration
Contributor
|
Potentially move the umbrella headers into an include folder |
Hibyehello
reviewed
Apr 3, 2026
Hibyehello
left a comment
Hibyehello
left a comment
Contributor
There was a problem hiding this comment.
We're at a good starting point, but I'll do a more thorough read through
| /** | ||
| * @brief Array to store task identifiers. | ||
| */ | ||
| T* task_identifiers; |
Contributor
There was a problem hiding this comment.
Suggested change
| T* task_identifiers; | |
| T** task_identifiers; |
We need it to be an array
| /** | ||
| * @brief Dispatcher for routing received frames to handlers. This is a reference to the singleton instance of the dispatcher, allowing the service to register handlers or dispatch received frames as needed. | ||
| */ | ||
| Dispatcher& dispatcher = Dispatcher::get_instance(); |
Contributor
There was a problem hiding this comment.
Suggested change
| Dispatcher& dispatcher = Dispatcher::get_instance(); | |
| Dispatcher* dispatcher; |
Let's just construct with the dispatcher instance
Move the core api into include for use with the hardware libraries
TODO: Fix TaskController
Also added many minor changes for actual implementation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.