Fix the object clone issue, close #49

[SYM01]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @SYM01, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical issue related to object persistence, specifically when attempting to save data structures that include JavaScript Proxy objects. By implementing a deep cloning mechanism, the system can now reliably store profile configurations and other relevant data, ensuring compatibility with underlying storage APIs that do not support direct serialization of Proxy objects. This change enhances the robustness of data handling within the application.

Highlights

• Deep Cloning Utility: A new utility function, deepClone, has been introduced in src/services/utils.ts to create a deep copy of objects. This function uses JSON.parse(JSON.stringify(obj)) to effectively strip out JavaScript Proxy objects.
• Object Persistence Fix: The deepClone function is now applied to ProxyProfile and ProfilesStorage objects before they are saved using Host.set in src/services/profile.ts and src/services/proxy/index.ts. This resolves an issue where storage mechanisms (like chrome.storage or browser.storage which use structured cloning) could not properly handle Proxy objects, leading to data saving failures.
• Dependency Metadata Update: Several peer: true entries have been removed from package-lock.json, likely as a result of dependency resolution or updates, though this is a secondary effect to the core bug fix.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a deepClone utility to address issues with saving Vue's reactive proxy objects to browser storage, using JSON.parse(JSON.stringify()). However, the implementation of profile saving in src/services/profile.ts is vulnerable to Prototype Pollution because it uses user-supplied profile IDs as keys in a plain JavaScript object without validation, which could allow an attacker to manipulate the extension's global state by polluting Object.prototype. Additionally, my review includes suggestions to remove redundant cloning operations to improve performance and maintainability, and a note on the limitations of the chosen cloning method for future consideration.

[gemini-code-assist]

This line is vulnerable to Prototype Pollution due to the use of user-controlled profile.profileID as a key in data. An attacker could use "__proto__" to inject properties into Object.prototype, which is then persistently saved. Furthermore, the deepClone call here is redundant, as the overwriteProfiles function, which is called subsequently, already performs a deep clone on the entire profiles object before saving.

  if (profile.profileID !== '__proto__') {
    data[profile.profileID] = deepClone(profile);
  }

[gemini-code-assist]

Similar to the saveProfile function, this line is vulnerable to Prototype Pollution if p.profileID is "__proto__". Additionally, the deepClone call within this forEach loop is redundant, as overwriteProfiles handles cloning the entire data structure.

    if (p.profileID !== '__proto__') {
      data[p.profileID] = deepClone(p);
    }

[gemini-code-assist]

Using JSON.parse(JSON.stringify(obj)) is a concise way to deep clone an object and remove Vue's reactivity proxies. However, this method has important limitations and can lead to data loss or type changes for non-JSON-serializable data (e.g., Date objects, undefined, functions) and will throw an error on circular references. While it works for the current ProxyProfile data structures, this fragility could lead to bugs if the data models evolve. Please consider adding a comment detailing these limitations for future maintainers.