Repository navigation
test(jco): share the TLS provider's shim instance - #2343
Closed
vados-cosmonic wants to merge 1 commit into
Closed
vados-cosmonic wants to merge 1 commit into
vados-cosmonic wants to merge 1 commit into
Conversation
Collaborator
Author
|
Going to leave this, because it's inadvertently a good way to test mismatches between jco and jco-std at release time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TLS integration fixture resolved WASI sockets from jco's preview2-shim 0.31.0 while its workspace TLS provider resolved preview2-shim 0.30.0. Passing streams between these instances caused eight tests to throw
Cannot read private member #id from an object whose class did not declare it, including seven tests using local servers.Resolve all fixture shim imports relative to the TLS provider so sockets, streams, and TLS share the same resource classes and IO worker even when the workspace packages use different shim versions.
Validation:
pnpm --filter @bytecodealliance/jco test test/node/https-wasi-tls.ts— all 12 tests passed.git diff --checkpassed.