Repository navigation
fix(transpile): handle escaped names and repair CI regressions - #2303
Merged
vados-cosmonic merged 3 commits intoOct 23, 2026
Merged
vados-cosmonic merged 3 commits into
vados-cosmonic merged 3 commits into
Conversation
vados-cosmonic
force-pushed
the
fix/main-transpile-ci-failures
branch
from
October 23, 2026 06:43
8ce0c3f to
66388a1
Compare
vados-cosmonic
enabled auto-merge
October 23, 2026 07:00
vados-cosmonic
force-pushed
the
fix/main-transpile-ci-failures
branch
from
October 23, 2026 07:08
66388a1 to
0f476a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated names now use escaped double-quoted literals, but callback diagnostic names and asm.js export rewriting still assumed the earlier quoting. Escape callback labels and decode core export literals before mangling them so async MoonBit exports and the asm.js flavorful component instantiate correctly. Update enum, resource-disposal, and import assertions to accept either quote style while preserving their behavioral checks.
Cache Chrome and Firefox installations for browser examples, with separate keys by example, OS, architecture, lockfile, and installer. This avoids repeated downloads and extraction on cache hits. The native-messaging job in the linked run lost its hosted runner during Firefox installation; its log is unavailable.
Add four commented WAT fixtures for numeric and escaped core export names, plus suspending and non-suspending JSPI callbacks whose names contain quotes, backslashes, and a newline. Each fixture explains the behavior it exercises, and the regression tests transpile and execute those fixtures.
Keep the public HTTPS smoke check focused on verified TLS transport: a valid HTTP error response such as 503 must not fail because the remote service is unavailable. Add a local 503 response case using the existing HTTPS component fixture, with exact status and body assertions, verified handshake checks, and resource cleanup checks. Certificate and hostname rejection checks remain strict.
Addresses failures from the extended job, the Node 22 transpile job, and repeated browser setup in the native-messaging job.