Skip to content

fix(transpile): handle escaped names and repair CI regressions - #2303

Merged
vados-cosmonic merged 3 commits into
bytecodealliance:mainfrom
vados-cosmonic:fix/main-transpile-ci-failures
Oct 23, 2026
Merged

vados-cosmonic merged 3 commits into
bytecodealliance:mainfrom
vados-cosmonic:fix/main-transpile-ci-failures

Conversation

@vados-cosmonic

@vados-cosmonic vados-cosmonic commented Oct 23, 2026 •

Copy link
Copy Markdown
Collaborator

Generated names now use escaped double-quoted literals, but callback diagnostic names and asm.js export rewriting still assumed the earlier quoting. Escape callback labels and decode core export literals before mangling them so async MoonBit exports and the asm.js flavorful component instantiate correctly. Update enum, resource-disposal, and import assertions to accept either quote style while preserving their behavioral checks.

Cache Chrome and Firefox installations for browser examples, with separate keys by example, OS, architecture, lockfile, and installer. This avoids repeated downloads and extraction on cache hits. The native-messaging job in the linked run lost its hosted runner during Firefox installation; its log is unavailable.

Add four commented WAT fixtures for numeric and escaped core export names, plus suspending and non-suspending JSPI callbacks whose names contain quotes, backslashes, and a newline. Each fixture explains the behavior it exercises, and the regression tests transpile and execute those fixtures.

Keep the public HTTPS smoke check focused on verified TLS transport: a valid HTTP error response such as 503 must not fail because the remote service is unavailable. Add a local 503 response case using the existing HTTPS component fixture, with exact status and body assertions, verified handshake checks, and resource cleanup checks. Certificate and hostname rejection checks remain strict.

Addresses failures from the extended job, the Node 22 transpile job, and repeated browser setup in the native-messaging job.

@vados-cosmonic
vados-cosmonic force-pushed the fix/main-transpile-ci-failures branch from 8ce0c3f to 66388a1 Compare October 23, 2026 06:43
@vados-cosmonic vados-cosmonic changed the title fix(transpile): repair CI after generated string escaping fix(transpile): handle escaped names and repair CI regressions Oct 23, 2026
@vados-cosmonic
vados-cosmonic force-pushed the fix/main-transpile-ci-failures branch from 66388a1 to 0f476a3 Compare October 23, 2026 07:08
@vados-cosmonic
vados-cosmonic added this pull request to the merge queue Oct 23, 2026
Merged via the queue into bytecodealliance:main with commit 2926dff Oct 23, 2026
66 checks passed
@vados-cosmonic
vados-cosmonic deleted the fix/main-transpile-ci-failures branch October 23, 2026 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant