Repository navigation
fix(transpile): preserve Unicode core export names in asm.js - #2302
Merged
vados-cosmonic merged 1 commit intoOct 23, 2026
Merged
vados-cosmonic merged 1 commit into
vados-cosmonic merged 1 commit into
Conversation
vados-cosmonic
enabled auto-merge
October 23, 2026 05:17
vados-cosmonic
force-pushed
the
fix/asmjs-unicode-export-names
branch
from
October 23, 2026 09:14
e1deb8e to
65cb4d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
--js, core exports containing non-ASCII characters can fail with a missing-functionTypeError. For example, an export namedline\u2028\u2029is looked up under a different name from the one emitted by wasm2js. Binaryen mangles UTF-8 bytes, whileasmManglepreviously operated on JavaScript's UTF-16 code units.Mangle one UTF-8 byte at a time to match Binaryen. Include the double-quoted export-name rewrite shared with #2301 so this fix works independently against main. Add execution regressions for ASCII names, escaped names, and leading or embedded two-, three-, and four-byte Unicode characters, with minification both enabled and disabled.
Validation from
packages/jco-transpile:pnpm exec vitest run -c test/vitest.lts.ts test/asm.ts— 20 passed.pnpm exec vitest run -c test/vitest.lts.ts test/transpile.ts -t 'transpile to JS|transpile, optimize, minify'— 2 passed.pnpm exec tsc -p tsconfig.json, affected-file oxlint and oxfmt checks, andgit diff --checkpassed.