Conversation
734ab70 to
c10f0f7
Compare
Codecov Report
@@ Coverage Diff @@
## main #319 +/- ##
==========================================
+ Coverage 62.73% 62.96% +0.22%
==========================================
Files 58 58
Lines 4286 4760 +474
==========================================
+ Hits 2689 2997 +308
- Misses 1382 1546 +164
- Partials 215 217 +2
Continue to review full report at Codecov.
|
a135d77 to
53e6bb9
Compare
|
will test tomorrow to ensure they actually run on the platforms |
|
ok got it running in stage and it seems fine, both sso_proxy and sso_auth |
| RUN ln -s /usr/bin/dpkg-split /usr/sbin/dpkg-split | ||
| RUN ln -s /usr/bin/dpkg-deb /usr/sbin/dpkg-deb | ||
| RUN ln -s /bin/tar /usr/sbin/tar | ||
| RUN ln -s /bin/rm /usr/sbin/rm |
There was a problem hiding this comment.
this was needed for the builds to complete. seems like the file locations are in different spots on the ARM arch.
There was a problem hiding this comment.
👍 Would it be worth adding this in a quick inline comment?
There was a problem hiding this comment.
if this remains, yes. i want to test the resultant multi-arch images in a arm64 cluster before finalizing this. i only got to test it once during hackweek before tearing down the temp cluster.
There was a problem hiding this comment.
i'm going to see if we need this for arm64, which is the primary secondary target we want for M1's and Graviton's
There was a problem hiding this comment.
that didn't work, these are needed for arm64 also apparently.
Makefile
Outdated
| docker buildx build --tag buzzfeed/sso:$(version) . --platform linux/amd64,linux/arm64,linux/arm/v7 --push | ||
| docker buildx build --tag buzzfeed/sso-dev:latest . --platform linux/amd64,linux/arm64,linux/arm/v7 --push |
There was a problem hiding this comment.
I think we might also want to push a buzzfeed/sso:latest tag. I'm also not particularly sure we really need the buzzfeed/sso-dev:latest tag to be honest. That tag should be created with each push to the main branch (through this logic), so I'm not sure we gain anything with it being here as well.
There was a problem hiding this comment.
thanks, this was a typo, should have been buzzfeed/sso:latest. fixing it.
53e6bb9 to
db2fc03
Compare
171ce40 to
db2fc03
Compare

Problem
current sso images don't support arm64 architecture. that means we can't run them on AWS Graviton's or Apple M1's
Solution
build a multi-arch with
linux/amd64,linux/arm64platform supportNotes
based on https://www.docker.com/blog/multi-arch-images/ and https://www.docker.com/blog/multi-arch-build-what-about-circleci/
our upstream,
golang:1.14supports these architectures and more