Conversation
|
Overall, I agree with the changeset. However, there are some open questions if you could investigate and respond to appropriately:
|
I think we could definitely improve the UX of this situation (and others) -- so far I've found this to trigger only static error pages which would then require a user to manually sign out using the
I think this depends if we want to maintain the usefulness of the current error page -- at the moment it tells users which domain and provider they can log in with, which I think is fairly useful information. Alternatively, we could try to move some logic surrounding this to the Proxy. (I've had an initial look at possibilities here, but have a few other possible avenues to look into) |
Problem
As a follow up to #247, this removes some redundant logic from the sso authenticator, particularly surrounding the
AUTHORIZE_EMAIL_DOMAINSandAUTHORIZE_EMAIL_ADDRESSESconfiguration variables.Solution
AUTHORIZE_EMAIL_ADDRESSESwas only used for email validation, which is already done in the proxy so this has been removed.AUTHORIZE_EMAIL_DOMAINSwas used in two places: email validation (which has also been removed) and population of the sign in page.Rather than needing to pass these domains in as configuration variables, (or reducing the usefulness of the sign in page) sso proxy adds the allowed domains to the SignInPage URL as a query parameter, which is then parsed by sso authenticator for use within the sign in page