Draft
Conversation
jphines
commented
May 23, 2019
| - run: | ||
| name: copy source | ||
| command: | | ||
| mkdir bin |
Contributor
Author
There was a problem hiding this comment.
This doesn't make much sense in context (it doesn't copy source!)
jphines
commented
May 23, 2019
| exit 1 | ||
| fi | ||
| echo "running golangci-lint ..." | ||
| golangci-lint run -E gofmt -E golint -E gocritic -E gosec -E misspell |
Contributor
Author
There was a problem hiding this comment.
This should move into a config file so running golangci-lint locally is consistent with what is run in CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
We have a limited number of linters and other static code analyzers. We should add more to improve our codebase and make review better and easier.
Solution
golangci-linthttps://github.com/golangci/golangci-lint is the newest replacement forgometalinterwhich has been the staple multi-lint tool. This PR adds support forgolangci-lintas well as fixes the codebase so it runs cleanly.Notes
Default linters include:
We also enable additional linters:
We can add other linters in the future but I'd like to focus on getting the defaults