refactor: refactor bundesanzeiger module and config to work concurect…#87
Open
FelixBehne wants to merge 8 commits intobundesAPI:mainfrom
Open
refactor: refactor bundesanzeiger module and config to work concurect…#87FelixBehne wants to merge 8 commits intobundesAPI:mainfrom
FelixBehne wants to merge 8 commits intobundesAPI:mainfrom
Conversation
…ly (performance gain of up to 300%), add utility functions and increase overall performance and fault tolerancy of code
Member
|
Hi, Thanks so much for your contribution. Great work 👏 I need some time for a deeper look. But from what I can tell from a quick look you used type hints which require python 3.10. (e.g dict) We should keep the min python version the same if possible. |
Member
|
HI @FelixBehne , Would you mind merging back main into your branch? I guess the import order changed due to isort. |
Member
|
Hi @FelixBehne , I merged back the current master. I included the changes for Would you mind looking over the merged changes if you see any problems due to the merge? I would really appreciate it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, while using the Bundesanzeiger module, I noticed some issues that I want to fix with this pull request for everyone.
I hope you find these improvements helpful and valuable. Thank you for considering this pull request ;)