Skip to content

fix: replace logger.Info(fmt.Sprintf(...)) with logger.Sugar().Infof(...)#128

Open
vwinee21 wants to merge 1 commit into
buildonspark:mainfrom
vwinee21:fix/zap-logging-sugar-sprintf
Open

fix: replace logger.Info(fmt.Sprintf(...)) with logger.Sugar().Infof(...)#128
vwinee21 wants to merge 1 commit into
buildonspark:mainfrom
vwinee21:fix/zap-logging-sugar-sprintf

Conversation

@vwinee21
Copy link
Copy Markdown

Summary

Replace logger.Info(fmt.Sprintf(...)) with logger.Sugar().Infof(...) in 5 files, following the Zap logging guidelines in CLAUDE.md.

Per the coding guidelines:

Bad - fmt.Sprintf in Logger message (defeats structured logging, use Sugar instead)

Files changed

  • spark/so/task/task.go (2 fixes)
  • spark/so/handler/tokens/validation.go (1 fix)
  • spark/so/handler/tokens/internal_sign_token_handler.go (1 fix)
  • spark/so/handler/tokens/start_token_handler.go (2 fixes)
  • spark/bin/operator/main.go (1 fix)

Public

Replace logger.Info(fmt.Sprintf(...)) with logger.Sugar().Infof(...) to follow Zap structured logging guidelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant