Rewrite the DAG transmission protocol - #29
Merged
Conversation
The existing protocol has the downside that it only informs whether a DAG has been written fully after the fact. This means that if a client wants to do retries, there is no way it can discard parts of the graph. To address this, we change the protocol as follows: - RequestObject has been split up: RequestObjectContents can be called up to once to request the object's contents. FinalizeObject needs to be called exactly once to report whether writing the object and its children has succeeded or not. - FinalizeTag has been added to inform a client whether writing a specific tag succeeded. - FinalizeDAG has been removed, as clients can simply keep track of the expected number of FinalizeObject and FinalizeTag messages. With this change implemented, we may start working on a proper buffer layer for bonanza_builder.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing protocol has the downside that it only informs whether a DAG has been written fully after the fact. This means that if a client wants to do retries, there is no way it can discard parts of the graph. To address this, we change the protocol as follows:
RequestObject has been split up: RequestObjectContents can be called up to once to request the object's contents. FinalizeObject needs to be called exactly once to report whether writing the object and its children has succeeded or not.
FinalizeTag has been added to inform a client whether writing a specific tag succeeded.
FinalizeDAG has been removed, as clients can simply keep track of the expected number of FinalizeObject and FinalizeTag messages.
With this change implemented, we may start working on a proper buffer layer for bonanza_builder.