Skip to content

Prototype: move Sass-Embedded to optionalDependencies#316

Open
acketon wants to merge 5 commits into
developfrom
dakota/fix-compile-build-issues-and-get-breadcrumb-prototype-loading
Open

Prototype: move Sass-Embedded to optionalDependencies#316
acketon wants to merge 5 commits into
developfrom
dakota/fix-compile-build-issues-and-get-breadcrumb-prototype-loading

Conversation

@acketon

@acketon acketon commented Nov 3, 2025

Copy link
Copy Markdown
Member

Description

This PR tests moving sass-embedded to the optionalDependencies. The documentation for webpack/sass-loader state that if you list sass-embedded as an optional dependency it will attempt to use it if it can, but if not, will fall back to using sass (dart-sass in JS). This seems to work in my testing and would let us eliminate the sassCompiler setting and modification of the sass-loader in @wordpress/scripts.

I could use some more help testing this though by using the command time before npm run build, etc. It's not easy to actually know which sass compiler is being used but going off the speed of the build should tell us if it is working. From my testing this works and it's slightly faster if I include sass-embedded in the optionalDependencies vs removing it everywhere.

Sandbox links

You can see my changes in the links below:


Browser support

I have tested my changes in the following browsers:

If your project requires browser testing beyond the latest two versions, such as IE9, please note this below.

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE11

Pre-review checklist for designers and developers

  • I have tested my changes in my sandbox and they are working correctly.
  • I have tested my changes in the browsers required for my project, and they are working correctly.
  • To the best of my knowledge, this code is stable and ready to be deployed to production or staging at any time.
  • My code follows BU Coding Standards.

Information for reviewers

…alDependency and removes the reference in webpack.config.js that is loading it manually. Webpack & SASS Loader should now decide to use sass-embedded if it can. Testing this approach
@acketon acketon changed the title Dakota/fix compile build issues and get breadcrumb prototype loading Prototype: move Sass-Embedded to optionalDependencies Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant