Repository navigation
added screenshot for debugging - #125
Merged
sauravpanda merged 2 commits intoOct 31, 2025
Merged
sauravpanda merged 2 commits into
sauravpanda merged 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
3 issues found across 6 files
Prompt for AI agents (all 3 issues)
Understand the root cause of the following 3 issues and fix them.
<file name="workflows/workflow_use/healing/deterministic_converter.py">
<violation number="1" location="workflows/workflow_use/healing/deterministic_converter.py:611">
Guard against agent_context['reasoning'] being None before calling .lower(); otherwise dynamic-ID clicks crash the converter.</violation>
</file>
<file name="workflows/workflow_use/workflow/semantic_executor.py">
<violation number="1" location="workflows/workflow_use/workflow/semantic_executor.py:381">
Priority 1 of _find_element_by_pattern ignores the requested pattern text and will pick the first ID-looking element even if it is unrelated, so hinted clicks may target the wrong entry. Please filter these matches using the requested pattern (e.g., compare against the actual ID string or required keywords) before appending them.</violation>
</file>
<file name="workflows/workflow_use/storage/service.py">
<violation number="1" location="workflows/workflow_use/storage/service.py:146">
Removing the `output` field here strips valid workflow outputs, so steps can no longer store their results in context; workflows depending on this will fail.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
|
|
||
| # Check agent reasoning for context to determine the semantic meaning | ||
| reasoning = agent_context.get('reasoning', '') if agent_context else '' | ||
| reasoning_lower = reasoning.lower() |
Contributor
There was a problem hiding this comment.
Guard against agent_context['reasoning'] being None before calling .lower(); otherwise dynamic-ID clicks crash the converter.
Prompt for AI agents
Address the following comment on workflows/workflow_use/healing/deterministic_converter.py at line 611:
<comment>Guard against agent_context['reasoning'] being None before calling .lower(); otherwise dynamic-ID clicks crash the converter.</comment>
<file context>
@@ -463,11 +587,70 @@ def _convert_action_to_step(
+
+ # Check agent reasoning for context to determine the semantic meaning
+ reasoning = agent_context.get('reasoning', '') if agent_context else ''
+ reasoning_lower = reasoning.lower()
+
+ original_target = target_text
</file context>
| 'position_hint', # Usually null | ||
| 'interaction_type', # Usually null | ||
| 'default_value', # Usually null for inputs | ||
| 'output', # Usually null |
Contributor
There was a problem hiding this comment.
Removing the output field here strips valid workflow outputs, so steps can no longer store their results in context; workflows depending on this will fail.
Prompt for AI agents
Address the following comment on workflows/workflow_use/storage/service.py at line 146:
<comment>Removing the `output` field here strips valid workflow outputs, so steps can no longer store their results in context; workflows depending on this will fail.</comment>
<file context>
@@ -123,8 +123,57 @@ def save_workflow(
+ 'position_hint', # Usually null
+ 'interaction_type', # Usually null
+ 'default_value', # Usually null for inputs
+ 'output', # Usually null
+ ]
+ for field in fields_to_remove:
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Added per-step debug screenshots and switched extraction steps to a lightweight, LLM-only flow to speed up runs and reduce cost. Also improved semantic targeting and matching for inputs, anchors, and dynamic IDs to make workflows more reliable and reusable. Implements Linear #124 by avoiding agent startup for content extraction.
New Features
extractandextract_page_contentsteps (no agent), using clean page markdown.Refactors
Written for commit ae75a84. Summary will update automatically on new commits.