fix: upgrade rig-core to 0.38 and jsonschema to 0.46 with API migration#1764
Draft
broomva wants to merge 4 commits into
Draft
fix: upgrade rig-core to 0.38 and jsonschema to 0.46 with API migration#1764broomva wants to merge 4 commits into
broomva wants to merge 4 commits into
Conversation
- Alias rig-core as `rig` in workspace deps to preserve existing `use rig::...` imports while upgrading from 0.36 to 0.38 (which renamed its lib to rig_core) - Bump jsonschema from 0.18 to 0.46 in workspace deps - Migrate all jsonschema call sites from deprecated JSONSchema::options().compile() / compiled.validate() API to the new jsonschema::compile() / compiled.iter_errors() API used in 0.26+ (affects ergon/agent.rs, arcan/agent_cmd.rs, and arcan-ergon tests) Addresses dependabot PRs #1752 (rig-core bump) and #1755 (jsonschema bump). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XqadKZDEB6J9WAAmuVkmoV
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Reformatted iter_errors chain to match rustfmt line-length limits. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XqadKZDEB6J9WAAmuVkmoV
jsonschema 0.46.x removed the top-level `compile()` free function. The correct entry point is `jsonschema::validator_for(schema)` which returns a `Validator`. The `iter_errors()` method API is unchanged. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XqadKZDEB6J9WAAmuVkmoV
ValidationError::instance_path changed from a field to a method in jsonschema 0.46.x. Add () to all call sites. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XqadKZDEB6J9WAAmuVkmoV
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rig-coreasrigin workspace deps to preserve all existinguse rig::...imports while upgrading from 0.36 to 0.38 (which renamed its internal lib torig_core). The Cargo dependency alias makesrustcmap--extern rig=librig_core.rlibso no source changes are needed inrig_bridge.rs.jsonschemafrom 0.18 to 0.46 in workspace deps, which contains a breaking API removal:JSONSchema::options().compile()andcompiled.validate()no longer exist.jsonschema::compile(schema)→Validator, thenvalidator.iter_errors(instance)for error iteration.Files changed
Cargo.tomlrig-core = "0.36"→rig = { package = "rig-core", version = "0.38" };jsonschema0.18 → 0.46crates/arcan/arcan-provider/Cargo.tomlrig-core.workspace→rig.workspacecrates/ergon/ergon/src/agent.rsvalidate_against_schema: new jsonschema 0.46 APIcrates/arcan/arcan/src/agent_cmd.rsvalidate_against_schema: new jsonschema 0.46 APIcrates/arcan/arcan-ergon/tests/anthropic_agents_smoke.rsassert_schema: new jsonschema 0.46 APIcrates/arcan/arcan-ergon/tests/agents_fixtures.rseach_blessed_agent_schema_compiles_under_production_validator: new APIAddresses dependabot PRs
Test plan
cargo check -p arcan-provider— rig alias resolves correctlycargo check -p ergon— jsonschema 0.46 API compilescargo check -p arcan— agent_cmd.rs compilescargo test -p ergon— schema validation tests passcargo test -p arcan-ergon— agents_fixtures schema compile test passes🤖 Generated with Claude Code
https://claude.ai/code/session_01XqadKZDEB6J9WAAmuVkmoV
Generated by Claude Code