Adding support for Amazon Athena#408
Open
brendan-cook-87 wants to merge 4 commits intobrooklyn-data:mainfrom
Open
Adding support for Amazon Athena#408brendan-cook-87 wants to merge 4 commits intobrooklyn-data:mainfrom
brendan-cook-87 wants to merge 4 commits intobrooklyn-data:mainfrom
Conversation
brendan-cook-87
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
brendan-cook-87
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
brendan-cook-87
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
brendan-cook-87
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
brendan-cook-87
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
brendan-cook-87
temporarily deployed
to
Approve Integration Tests
GitHub Actions
Inactive
brendan-cook-87
temporarily deployed
to
Approve Integration Tests
GitHub Actions
Inactive
brendan-cook-87
temporarily deployed
to
Approve Integration Tests
GitHub Actions
Inactive
brendan-cook-87
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
brendan-cook-87
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
brendan-cook-87
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
brendan-cook-87
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
brendan-cook-87
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
brendan-cook-87
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
brendan-cook-87
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
brendan-cook-87
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
brendan-cook-87
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
brendan-cook-87
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
brendan-cook-87
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
brendan-cook-87
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
brendan-cook-87
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
brendan-cook-87
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
brendan-cook-87
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Adds support Amazon Athena.
Update type - breaking / non-breaking
What does this solve?
Adding Amazon Athena support as per feature request.
Outstanding questions
I am a bit unsure about a few pieces of the dbt_project config. I have added table_type and incrememntal_strategy config conditionally for Athena, but I haven't tested how these affect other databases.
The additional config in the incremental test model is required because by default in Athena if you cast 'apple' to varchar the default response creates a varchar(5) column which doesn't accept a varchar(6) - 'banana', unless you select a table_type that allows for (some) schema evolution (iceberg).
What databases have you tested with?