V1.0.0 beta.2#395
Conversation
commit de82483 Author: Leo Dion <leogdion@brightdigit.com> Date: Sun May 17 21:14:35 2026 +0100 git subrepo push Examples/CelestraCloud subrepo: subdir: "Examples/CelestraCloud" merged: "ea897c3" upstream: origin: "git@github.com:brightdigit/CelestraCloud.git" branch: "mistkit" commit: "ea897c3" git-subrepo: version: "0.4.9" origin: "https://github.com/Homebrew/brew" commit: "6f293daa9f" commit 24c8719 Author: Leo Dion <leogdion@brightdigit.com> Date: Sun May 17 21:14:31 2026 +0100 git subrepo push Examples/BushelCloud subrepo: subdir: "Examples/BushelCloud" merged: "5bb4490" upstream: origin: "git@github.com:brightdigit/BushelCloud.git" branch: "mistkit" commit: "5bb4490" git-subrepo: version: "0.4.9" origin: "https://github.com/Homebrew/brew" commit: "6f293daa9f" commit eee0670 Author: Leo Dion <leogdion@brightdigit.com> Date: Sun May 17 21:14:13 2026 +0100 docs: sync README/CLAUDE examples to v1.0.0-beta.1 API; pin BushelCloud CI; exclude internal Python from CodeFactor - README.md, Examples/BushelCloud/{CLAUDE.md,.docc,.claude/s2s-auth-details.md}, Examples/CelestraCloud/{CLAUDE.md,README.md,.claude/IMPLEMENTATION_NOTES.md}: drop `try CloudKitService(... database: .public)` from init examples (init is non-throwing, `database:` moved per-call); rewrite Quick Start auth around `Credentials` + `APICredentials` / `ServerToServerCredentials` and show `database: .public(.prefers(.serverToServer))` at the call site. - Examples/BushelCloud/.github/workflows/{BushelCloud.yml,bushel-cloud-build.yml}: pin MISTKIT_BRANCH to v1.0.0-beta.1 (matches CelestraCloud) so the subrepo PR builds against the branch that actually carries the new API. Revert to `main` once #298 merges. - .codefactor.yml: exclude Scripts/mermaid-to-pptx.py (internal-use helper). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> commit 4d60b19 Author: Leo Dion <leogdion@brightdigit.com> Date: Sun May 17 20:10:45 2026 +0100 git subrepo push Examples/CelestraCloud subrepo: subdir: "Examples/CelestraCloud" merged: "c44dc4f" upstream: origin: "git@github.com:brightdigit/CelestraCloud.git" branch: "mistkit" commit: "c44dc4f" git-subrepo: version: "0.4.9" origin: "https://github.com/Homebrew/brew" commit: "6f293daa9f" commit 5bc403d Author: Leo Dion <leogdion@brightdigit.com> Date: Sun May 17 20:10:40 2026 +0100 git subrepo push Examples/BushelCloud subrepo: subdir: "Examples/BushelCloud" merged: "55f2092" upstream: origin: "git@github.com:brightdigit/BushelCloud.git" branch: "mistkit" commit: "55f2092" git-subrepo: version: "0.4.9" origin: "https://github.com/Homebrew/brew" commit: "6f293daa9f" commit bce1f23 Author: leogdion <leogdion@brightdigit.com> Date: Sun May 17 20:09:47 2026 +0100 refactor!: prep for talk — shrink API, refactor auth, split OpenAPI (#279) commit 7023a31 Author: leogdion <leogdion@brightdigit.com> Date: Fri May 15 12:56:58 2026 -0400 Fixed Nonisolated Web Auth Token (#347) commit f799128 Author: leogdion <leogdion@brightdigit.com> Date: Thu May 14 20:27:28 2026 -0400 Add MistDemo-Integration workflow for live CloudKit runs (#345) commit 418e2e4 Author: leogdion <leogdion@brightdigit.com> Date: Thu May 14 16:03:04 2026 -0400 Resolve #342: v1.0.0-beta.1 follow-ups (#341 #327 #321 #317) + CI fixes (#343) commit d65d20b Author: leogdion <leogdion@brightdigit.com> Date: Thu May 14 11:25:10 2026 -0400 Resolve #330: interactive MistDemo (web toggle + native app refresh) (#332) commit a28ab3c Author: leogdion <leogdion@brightdigit.com> Date: Mon May 11 16:31:10 2026 -0400 Resolve #313: paginationLimitExceeded carries accumulated records (#326) commit 7a5da7a Author: leogdion <leogdion@brightdigit.com> Date: Sat May 9 17:09:53 2026 -0400 Fix CI failures + Claude review nits on PR #298 (v1.0.0-beta.1) (#322) commit b3626c0 Author: leogdion <leogdion@brightdigit.com> Date: Sat May 9 16:06:20 2026 -0400 Resolve #312: public+web-auth user-identity endpoints (#310, #311, #27, #28, #34, #35) (#315) * #312 library: add public+web-auth user-identity endpoints and users/caller migration Implements the library side of #312 — adding/renaming user-identity endpoints that require public-database routing with web-auth (user-context) credentials, and unblocking the convenience initializers from their hardcoded database/ environment defaults. #310: `CloudKitService` convenience initializers now accept `database:` and `environment:` parameters with defaults that preserve current behavior. #311: `users/current` → `users/caller`. Renamed in openapi.yaml and the generated client; added a hand-written `fetchCaller()` plus an `@available(*, deprecated, renamed: "fetchCaller")` `fetchCurrentUser()` shim that forwards to the new method. #28: GET `/users/discover` (`discoverAllUserIdentities`). #34: POST `/users/lookup/email` (`lookupUsersByEmail`). #35: POST `/users/lookup/id` (`lookupUsersByRecordName`). The three new endpoints reuse `DiscoverResponse` for parsing — Apple returns `{ users: [UserIdentity] }` for all of them. Each ships with a 5-file test suite mirroring the existing `DiscoverUserIdentities` pattern. #33 (`users/lookup/contacts`) intentionally not implemented: Apple has marked the endpoint deprecated. To be closed as not-planned with a pointer to #34/#35. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * #312 MistDemo: separate database from authentication and add user-context phases Refactors MistDemo's CloudKit configuration model and integration runner to support the public+web-auth combination required by the user-identity endpoints landed in the prior commit. **Configuration refactor.** Replaces the `DatabaseCredentials` enum (which coupled database choice to a single auth method per case, baking in a public⇒S2S/private⇒webAuth assumption) with two orthogonal types: - `AuthenticationCredentials` — `serverToServer(keyID:privateKey:)` / `webAuth(apiToken:webAuthToken:)` - `DatabaseConfiguration` — pairs a `MistKit.Database` with an `AuthenticationCredentials`. The `make(database:authentication:)` factory rejects private+S2S and shared+S2S (which CloudKit rejects) so invalid combinations remain unrepresentable, while public+webAuth is now a valid construction. `MistKitClientFactory.create(for:)` consumes `toPrimaryConfiguration()`; the new `createUserContext(for:)` returns the optional public+web-auth service from `toUserContextConfiguration()` when web-auth tokens are configured. **Phase plumbing.** `PhaseContext` and `IntegrationTestRunner` now thread an optional `userContextService: CloudKitService?`. `PublicDatabaseTest` takes `includeUserContextPhases:` and conditionally appends the new user-identity phases: - `FetchCallerPhase` (renamed from `FetchCurrentUserPhase`) - `DiscoverUserIdentitiesPhase` (existed; updated to use userContextService) - `DiscoverAllUserIdentitiesPhase` (#28) - `LookupUsersByEmailPhase` (#34) - `LookupUsersByRecordNamePhase` (#35) `PrivateDatabaseTest` no longer includes `FetchCurrentUserPhase`: CloudKit rejects `users/caller` against the private database, matching the rest of the user-identity family. **Call-site updates.** `CurrentUserCommand` and `DemoErrorsRunner` swap `fetchCurrentUser()` → `fetchCaller()`. `TestIntegrationCommand` and `TestPrivateCommand` now build and pass `userContextService`. Tests for `AuthenticationCredentials`, `DatabaseConfiguration.make` validation, and `MistDemoConfig.toPrimaryConfiguration` / `toUserContextConfiguration` ship alongside. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * #312: mark discoverAllUserIdentities() unavailable pending #28 investigation Live verification on 2026-05-08 against iCloud.com.brightdigit.MistDemo returned HTTP 500 from Apple's GET /users/discover. The first 12 phases of mistdemo test-integration --verbose run green (the 8 base public+S2S phases plus FetchCallerPhase, DiscoverUserIdentitiesPhase, LookupUsersByEmailPhase, LookupUsersByRecordNamePhase) — only discoverAllUserIdentities fails, blocking phases beyond it. The endpoint is referenced in CloudKitJS but does not appear in Apple's CloudKit Web Services REST documentation. The actual REST shape is still under investigation under #28. Changes: - Marked `CloudKitService.discoverAllUserIdentities()` `@available(*, unavailable, message: ...)` with a pointer to #28. - Removed `DiscoverAllUserIdentitiesPhase` from MistDemo and from `PublicDatabaseTest.phases`. - Removed the `CloudKitServiceDiscoverAllUserIdentities` test directory (the unavailable method cannot be called from Swift code). The OpenAPI definition, generated client, path builder, response processor, Output extension, and Swift wrapper are all retained. Unblocking is a one-line `@available` removal once the correct REST shape is determined under #28. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * #315: resolve PR review — Credentials API, per-call database, cascade unavailable Addresses all four review threads on PR #315: - Comment #1 (error wording): removed `unsupportedDatabaseAuthCombination` along with `MistDemo.DatabaseConfiguration`; invalid combos now surface as `CloudKitError.missingCredentials` from the library. - Comment #2 (per-call database): user-identity ops in `CloudKitService+UserOperations` hardcode `.public`; record/zone/asset/sync ops accept `database: Database? = nil` falling back to a service-level default. - Comment #3 (unified credentials): new `Credentials` / `ServerToServerCredentials` / `APICredentials` value types replace the legacy `apiToken:`/`webAuthToken:` initializers. The token manager is selected based on the target database (S2S for `.public`, web-auth for `.private`/`.shared`). Lifted `PrivateKeyMaterial` into the library. - Comment #4 (cascade unavailable): removed `Operations.discoverAllUserIdentities.Output: CloudKitResponseType` conformance entirely; `processDiscoverAllUserIdentitiesResponse` is now `@available(*, unavailable)` with a `fatalError` body. Also migrates ~15 MistKit test helpers and the MistDemo factory to the new Credentials API. Breaking changes (pre-1.0): removed legacy `CloudKitService` initializers taking `apiToken:`/`webAuthToken:`; `CloudKitService.apiToken` is removed, `.database` is now `internal`. Out of scope: per-call `TokenManager` dispatch (would let one service mix S2S-for-public and web-auth-for-user-context). MistDemo still constructs a separate `userContextService` for that scenario. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * #315: drop service-level database, per-call credential resolution [skip ci] Resolves the architectural feedback in the PR-315 review: * CloudKitService no longer carries `database` — operations take `database:` per call (defaulting to `.public`); user-identity routes drop the parameter since CloudKit pins them to `.public`. Subsumes Claude's "fetchCaller bypasses self.database" finding. * Credentials.makeTokenManager(for:requiresUserContext:) resolves the appropriate token manager at dispatch time. A single service can now serve public-database S2S record ops and user-identity web-auth routes from one fully-populated `Credentials`. MistKitClient.swift is obsolete and removed; per-call dispatch lives in CloudKitService+ClientDispatch. * Credentials.swift split per SwiftLint one_file_per_declaration into ServerToServerCredentials.swift + APICredentials.swift + Credentials.swift. New typed CredentialsValidationError; init asserts in debug, throws in release (no more precondition crash for dynamic config). * MistDemo: userContextService workaround collapsed — single service handles all phases via per-call resolution. * CI hotfix: 11 unused `public import` lines demoted to `internal` (the warnings-as-errors regression flagged in the review). * Tests: 12-case routing-matrix unit suite for makeTokenManager and a fetchCaller suite parallel to LookupUsers* (success + validation). Obsolete MistKitClient tests removed. * Polish: shorter @available message on discoverAllUserIdentities, structural comment for GET /users/discover in openapi.yaml, ConfigurationError.missingAPIToken (unused) removed. 475/475 tests pass. Library + MistDemo build clean. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * Per review on PR #315: listZones, lookupZones, fetchZoneChanges now default to .private since the public database only contains _defaultZone, making .public a degenerate default. MistDemo callers pass context.database / config.base.database explicitly so the --database flag still drives the test runs. Also repairs MistDemo test breakage from 7debe8d: toUserContextCredentials() was removed but tests still referenced it; rewritten against the replacement surface (toPrimaryCredentials embeds apiAuth on .public, plus the new hasUserContextCredentials boolean). The CredentialsValidationTests suite was deleted — it asserted init-time validation that no longer exists under per-call credential resolution; the equivalent .missingCredentials behavior is covered in MistKitTests. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * #312: gate @available(*,unavailable) on processDiscoverAllUserIdentitiesResponse to Swift 6.2+ Swift 6.1 rejects calls to an unavailable function from within another unavailable function; 6.2 relaxed that rule. The internal helper processDiscoverAllUserIdentitiesResponse is unavailable in lockstep with its only caller — the also-unavailable CloudKitService.discoverAllUserIdentities() — which built fine on 6.2+ but failed on Swift 6.1 with: error: 'processDiscoverAllUserIdentitiesResponse' is unavailable: Pending #28: discoverAllUserIdentities is not yet ready. Wrap just the attribute in `#if swift(>=6.2)` so the body is shared and 6.1 compiles. Inline doc records the intent and the one-line cleanup (delete the #if/#endif) once 6.1 is dropped from the matrix. A `swiftlint:disable:next unavailable_function` is required because swiftlint does not evaluate #if and otherwise sees a fatalError-only function without the attribute. Verified: swift build + swift test pass on Swift 6.1.3 (Linux container) and on macOS Swift 6.2+ (475/475 tests). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * #315: split unhandled-response logging into debug (full body) + warning (type/status only) CodeQL's swift/cleartext-logging flagged the existing warning logs because lookupUsersByEmail(_:) propagates email-PII taint through the response object. Move full \(response) interpolation to .debug so the detail stays available for development without flowing into ops logs; keep .warning at type(of:) + HTTP status code only. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * #312: add --lookup-email / CLOUDKIT_LOOKUP_EMAIL to exercise users/lookup/email LookupUsersByEmailPhase previously skipped whenever fetchCaller() didn't return an email (which is the common case). Plumb a configurable lookup email through TestIntegrationConfig / TestPrivateConfig → PhaseContext so the phase can be driven against a known-discoverable iCloud account. Falls back to caller email, then to a clearer skip message naming the flag/env var. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs: point CLAUDE.md lint section at mise (and Scripts/lint.sh) swift-format / swiftlint / periphery are pinned in mise.toml; the previous "requires swiftlint installation" wording led to PATH lookups that fail in this repo. Replace with `mise exec --` invocations and flag the full ./Scripts/lint.sh pipeline. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * #315: address review punch list — invalidPrivateKey, recoverable unavailable response, supportsUserContextPhases derivation - CloudKitError: add invalidPrivateKey(path:underlying:) so PEM-load failures carry the file path + original error instead of bare Foundation NSError. Wrap loadPEM() at the single call site in Credentials+TokenManager. Add PrivateKeyMaterial.filePath accessor for the diagnostic. - processDiscoverAllUserIdentitiesResponse: replace fatalError with throw CloudKitError.unsupportedOperationType so a stray Swift 6.1 caller (where the @available cascade does not apply) gets a recoverable error instead of a crash. - TestPrivateCommand: derive supportsUserContextPhases from config.base.hasUserContextCredentials, mirroring TestIntegrationCommand, so user-identity phases skip cleanly when web-auth env vars are absent. - toPrimaryCredentials: replace try? with do/catch + stderr INFO line so operators see when web-auth is missing on a .public setup. - CLAUDE.md: annotate discoverAllUserIdentities() as unavailable pending #28. - CredentialsTokenManagerTests: fill the missing routing-matrix branches (user-context × .private/.shared, .shared + token-only) and cover the new .invalidPrivateKey path. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> commit 6f92a71 Author: leogdion <leogdion@brightdigit.com> Date: Fri May 8 13:16:56 2026 -0400 Resolve #308: docs refresh + CI fixes + sub-issues #165, #285 (#309) commit a1e2162 Author: leogdion <leogdion@brightdigit.com> Date: Fri May 8 07:16:10 2026 -0400 Add query pagination support with continuation markers (#306) commit c62bf44 Author: leogdion <leogdion@brightdigit.com> Date: Thu May 7 15:52:45 2026 -0400 Improve error handling: typed TokenManagerError and safe RecordOperation conversion (#305) commit 7c4b678 Author: leogdion <leogdion@brightdigit.com> Date: Thu May 7 11:27:10 2026 -0400 git subrepo push Examples/CelestraCloud subrepo: subdir: "Examples/CelestraCloud" merged: "4244497" upstream: origin: "git@github.com:brightdigit/CelestraCloud.git" branch: "mistkit" commit: "4244497" git-subrepo: version: "0.4.9" origin: "https://github.com/Homebrew/brew" commit: "b9763ee528" commit f14e751 Author: leogdion <leogdion@brightdigit.com> Date: Thu May 7 11:27:07 2026 -0400 git subrepo push Examples/BushelCloud subrepo: subdir: "Examples/BushelCloud" merged: "123a732" upstream: origin: "git@github.com:brightdigit/BushelCloud.git" branch: "mistkit" commit: "123a732" git-subrepo: version: "0.4.9" origin: "https://github.com/Homebrew/brew" commit: "b9763ee528" commit a0f0af9 Author: leogdion <leogdion@brightdigit.com> Date: Thu May 7 11:26:32 2026 -0400 updating example packages commit 125dab5 Author: leogdion <leogdion@brightdigit.com> Date: Thu May 7 11:01:18 2026 -0400 Refactor AuthenticationMiddleware so each Authenticator applies itself (#294) commit f989fd1 Author: leogdion <leogdion@brightdigit.com> Date: Thu May 7 10:23:23 2026 -0400 Strengthen environment and database configuration validation (#293) commit b0f00a7 Author: leogdion <leogdion@brightdigit.com> Date: Thu May 7 10:18:52 2026 -0400 Add operation classification and batch sync result tracking (#296) commit 63a4e50 Author: leogdion <leogdion@brightdigit.com> Date: Thu May 7 10:09:27 2026 -0400 Move CloudKitResponseType default implementations to protocol extension (#292) commit ae1af15 Author: leogdion <leogdion@brightdigit.com> Date: Wed May 6 20:20:44 2026 -0400 Test suite improvements for v1.0.0-beta.1 (#286) (#287) commit 5475bfa Author: leogdion <leogdion@brightdigit.com> Date: Tue May 5 20:21:32 2026 -0400 MistDemo: --database flag + demo-errors command (closes #259, #269) (#282) commit 8b21425 Author: leogdion <leogdion@brightdigit.com> Date: Tue May 5 20:21:17 2026 -0400 Refactor IntegrationTestRunner into protocol-based phase pipeline (#254) (#283) commit 9709f3d Author: leogdion <leogdion@brightdigit.com> Date: Tue May 5 08:54:16 2026 -0400 Replace custom AsyncChannel with swift-async-algorithms (#280) commit d53467a Author: leogdion <leogdion@brightdigit.com> Date: Mon May 4 12:49:25 2026 -0400 CI Updates for May 2026 (#277) commit d7b1a21 Author: Leo Dion <leogdion@brightdigit.com> Date: Thu Apr 30 09:39:09 2026 -0400 MistDemo improvements: test split, CRUD, auth fix, native app (#271) (#273) commit 0ab2ab6 Author: leogdion <leogdion@brightdigit.com> Date: Wed Apr 29 15:49:34 2026 -0400 First Draft Revision of Docs (#268)
Adds four DocC articles to close out the open documentation gaps tracked by parent issue #361: - HandlingErrors.md — three-layer error model (construction, token, request) with retry/recovery guidance. - ConfiguringMistKit.md — container/environment/transport/logging inputs; defers credential construction to AuthenticationAndDatabases. - WorkingWithRecords.md — CRUD, batch, lookup, and sync-via-token walks. - CloudKitLimitsAndPerformance.md — pagination guard, batch sizing, asset upload transport split, rate limits. Also adds inline `# Example` blocks to createRecord, updateRecord (CloudKitService+WriteOperations.swift) and lookupRecords (CloudKitService+LookupOperations.swift) to match the existing example style on queryRecords. modifyRecords and deleteRecord examples live in the WorkingWithRecords article rather than inline to keep the write- operations file under the file_length cap. Updates Documentation.md Topics to surface the new articles and adds an Error Handling group covering the typed error and reason enums. Migration guide (mentioned in #160) is deferred — MistKit is at 1.0.0-beta.x with no stable predecessor; that article should land alongside a future release transition. Closes #115 Closes #116 Closes #160 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Updates the internals doc to match the current source: - `RequestSignature` parameter is `webServiceSubpath`, not `webServiceURL` (S2S sequence diagram, signing-payload template, both initializer labels, and the embedded code example). - Token-Manager-Selection flowchart no longer labels the `APITokenAuthenticator` arrow as "user-attributed" — API-token-only is neither of the two CloudKit attribution modes defined by `PublicAuthPreference`. - Drop stale reference to `downgradeToAPIOnly()` / `updateWebAuthToken(_:)`; only `upgradeToWebAuthentication(_:)` exists. - Fix `Credentials/Credentials+TokenManager.swift` path — the file lives directly under `Authentication/`, not in a `Credentials/` subdirectory. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Finishes the Zone API surface called out in #367 as "not shipped": single-zone create/delete convenience helpers over modifyZones, and the auto-paginating fetchAllZoneChanges (carve-out from #307). Library: - createZone / deleteZone (flat-param, mirrors createRecord pattern) - fetchAllZoneChanges with maxPages ceiling, cancellation check, stuck-token detection, and invalid-response guard - zonePaginationLimitExceeded sibling case on CloudKitError so the partial-results contract stays typed [ZoneInfo] rather than [RecordInfo] MistDemo: - create-zone / delete-zone CLI subcommands - ZoneRoundtripPhase + FetchAllZoneChangesPhase in PrivateDatabaseTest so the new endpoints are exercised against live CloudKit Closes #45, #47, #48 (audited as shipped per the parent issue), plus the zone-changes paginator carve-out from #307. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The live MistDemo integration tests targeted a CloudKit record type "MistKitIntegrationTest" that is not defined in the container schema, causing CI failures. The deployed schema only defines a Note record type with title/index/image fields, which the phases already populate. https://claude.ai/code/session_01EvLrWZwcSs1MjiCrUx8KjU
subrepo: subdir: "Examples/BushelCloud" merged: "7f026ac" upstream: origin: "git@github.com:brightdigit/BushelCloud.git" branch: "mistkit" commit: "7f026ac" git-subrepo: version: "0.4.9" origin: "https://github.com/Homebrew/brew" commit: "6f293daa9f"
subrepo: subdir: "Examples/CelestraCloud" merged: "dbdba1a" upstream: origin: "git@github.com:brightdigit/CelestraCloud.git" branch: "mistkit" commit: "dbdba1a" git-subrepo: version: "0.4.9" origin: "https://github.com/Homebrew/brew" commit: "6f293daa9f"
subrepo: subdir: "Examples/CelestraCloud" merged: "910b9fb" upstream: origin: "git@github.com:brightdigit/CelestraCloud.git" branch: "mistkit" commit: "910b9fb" git-subrepo: version: "0.4.9" origin: "https://github.com/Homebrew/brew" commit: "af835384ac"
subrepo: subdir: "Examples/BushelCloud" merged: "fa92cff" upstream: origin: "git@github.com:brightdigit/BushelCloud.git" branch: "main" commit: "fa92cff" git-subrepo: version: "0.4.9" origin: "https://github.com/Homebrew/brew" commit: "af835384ac"
The preceding force-pull (27eebaf) used clone --force semantics and silently retargeted to upstream's default branch (main). The recorded commit fa92cff is upstream mistkit's HEAD, so only the branch field needed correcting. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Important Review skippedToo many files! This PR contains 300 files, which is 150 over the limit of 150. To get a review, narrow the scope: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (300)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Code Review — v1.0.0-beta.2This is a large, well-structured release that adds subscriptions, APNs token management, web-courier long-polling, asset re-referencing, a richer error model, and a generic phantom-typed batch-result system. The overall quality is high. Below are findings organized by area. Overview of Changes
What's Working Well
Issues and SuggestionsBug:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #395 +/- ##
==========================================
+ Coverage 68.95% 71.40% +2.45%
==========================================
Files 111 168 +57
Lines 2641 3844 +1203
==========================================
+ Hits 1821 2745 +924
- Misses 820 1099 +279
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Code Review — v1.0.0-beta.2Reviewed at high effort (3 finder angles × verify). Six findings survived verification, ranked by severity. 🔴 Bug 1 — CDN asset upload uses
|
Handle the incompleteResponse, subscriptionOperationFailed, and subscriptionLikelyDuplicate cases added to CloudKitError so the CelestraCloud example builds. All three are classified as non-retriable. https://claude.ai/code/session_01WY9rXuEkERRMMnLDz2872H
* Wire landed MistKit endpoints into MistDemo web app (#394) Replace the nine 501 "pending" stubs in MistKit-server mode with real Hummingbird handlers that forward to the already-shipped CloudKitService wrappers, restoring parity with CloudKit JS mode: records/lookup, records/changes, zones/list, zones/lookup, zones/changes, users/caller, users/discover, users/lookup/email, users/lookup/id - WebBackend gains nine webXxx methods; CloudKitService conforms via thin forwards split across +Reads (records/zones) and +Users extensions. - New request DTOs (WebRequests+Records/+Users, extended +Zones) and response DTOs (RecordChanges, ZoneChanges, Caller, Users). User routes carry no database selector — they run on the public DB with web-auth. - records/lookup surfaces per-record failures via try get(), matching the webModifySubscriptions precedent. - addUnwiredLandedEndpoints removed; WebServer+Pending now lists only records/resolve (#41, no wrapper yet). - The browser already branched to these /api/* routes in MistKit mode, so no front-end change was needed — wiring the server flips them off the stub. Tests: MockBackend extended with the nine methods + call captures; forwarding and 401-unauthorized tests per route. 963 MistDemo tests pass; swift-format, swiftlint, and header checks clean. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * Address PR #396 review: discover-only user lookup + honest lookup semantics Demo web app now exposes only the non-deprecated POST /users/discover for user-identity lookup; the Apple-deprecated /users/lookup/email and /users/lookup/id routes are removed from every layer (route, protocol, conformance, DTO, mock, tests, frontend). Discover accepts emails AND user record names, forwarded as UserIdentityLookupInfo entries; phone-number support is tracked in #398. webLookupRecords keeps its all-or-nothing behavior, but the comment now honestly describes it (dropping the misleading "matches webModifySubscriptions" claim) and a new test locks the semantic: a per-record backend failure surfaces as 500, not a partial 200. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Code Review — v1.0.0-beta.2 (#395)
OverviewBeta.2 adds the following new surface area on top of beta.1:
The overall code quality is high. Architecture is coherent, typed throws are used throughout, import access modifiers are consistent, platform guards are present where needed, and the documentation is detailed and correct. Issues and Suggestions1.
|
| Priority | Issue |
|---|---|
| Moderate | modifyZones doc claims client-side public-DB rejection that does not exist in the code |
| Moderate | precondition in public SubscriptionInfo.init hard-crashes in production |
| Minor | try? in Courier.pollOnce silently drops decode errors |
| Minor | 250 ms backoff and stuck-token break are not observable |
Overall the PR is solid and the feature set matches the release notes. The two moderate items are worth addressing before tagging.
Generated with Claude Code
Code Review — PR #395 · V1.0.0 beta.2Scope: 1,110 files, +35,533/−5,390 lines. The diff is too large to retrieve via the API, so this review focuses on the new MistKit core surface (subscriptions, zones, APNs tokens, asset re-reference, batch chunking, web courier) based on direct inspection of the source tree. OverviewThis release adds substantial new API surface on top of CloudKit Web Services:
The architecture is consistent with beta.1. Every public function uses typed Code Quality & Style ✅
Issues & Suggestions1. Misleading doc comment in
|
| Feature | Test Files |
|---|---|
| Subscriptions | CloudKitServiceTests.Subscriptions+{SuccessCases,FailureCases,LikelyDuplicateCases,Helpers} |
| Zones (create/delete/modify) | CloudKitServiceTests.{CreateZone,DeleteZone,ModifyZones,FetchZoneChanges}+* |
| APNs Tokens | CloudKitServiceTests.Tokens+{SuccessCases,FailureCases} |
| Asset Rereference | CloudKitServiceTests.Rereference+{SuccessCases,Compose,ComposeErrors} |
| Batch Chunking | CloudKitServiceTests.BatchChunking+{LookupAllRecords,UserIdentityChunking} |
Possible gap: the compose overloads in rereferenceAsset use only results.first — confirm Rereference+ComposeErrors covers the case where lookupRecords returns more than one result (and verifies only the first is used), not just the case where zero are returned.
Security
- APNs token values are transmitted only to CloudKit API endpoints (no third-party logging exposure beyond what
LoggingMiddlewareemits at.debug). Consistent with the existing "no built-in redaction" policy. webcourierURLfromcreateAPNsTokenis validated as aURLbefore storing. No SSRF risk since the value originates from a trusted Apple API.- No new input-validation surface that could introduce injection issues.
Summary
This is high-quality, well-structured code. The three items worth acting on before merge:
- Fix or remove the "rejected here" claim in
modifyZonesdocs (correctness). - Remove the
database: .privatedefault fromfetchAllZoneChangesto stay consistent with the rest of the API (convention, silent-bug risk). - Evaluate the
preconditioninSubscriptionInfo.init— if production crash on misuse is intentional, document it clearly in the public API docs; if not, consider a throwing init.
Everything else is minor polish. The subscription machinery (especially the delete-ack filtering via init? and the isLikelyDuplicate heuristic) is particularly thoughtful. LGTM with the above addressed.
🤖 Generated with Claude Code
PR Review: V1.0.0 beta.2This is a substantial release branch touching ~1100 files. I focused on the new library surface and the structural changes. What's solidConfigKeyKit extraction (
Zone API additions Issues / suggestions1. // SubscriptionInfo.swift:102
precondition(!firesOn.isEmpty, "Query subscription firesOn must not be empty.")
The four static factories ( 2. Third-party CI actions not SHA-pinned (low — security best practice) In uses: codecov/codecov-action@v6 # should be pinned to full SHA
uses: sersoft-gmbh/swift-coverage-action@v5
uses: jlumbroso/free-disk-space@v1.3.1
3.
4. CloudKit caps subscriptions at 100 per database, so a 5. Minor: /// - Parameters:
/// - base: Base key string (e.g., "sync.dry_run")
/// - defaultVal: Required default valueCLAUDE.md says "no multi-paragraph docstrings or multi-line comment blocks — one short line max." These are multi-line parameter docs. Very minor, but worth flagging for consistency with the project's lean comment convention. SummaryThe core library additions (subscriptions, zone CRUD, batch auto-chunking, Otherwise this looks ready to merge. |
Add data-flow, component-architecture, MistKit-integration, and CloudKit schema-relationship diagrams to the Architecture and CloudKit Schema sections, replacing the prior ASCII art. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
subrepo: subdir: "Examples/CelestraCloud" merged: "cfab860" upstream: origin: "git@github.com:brightdigit/CelestraCloud.git" branch: "mistkit" commit: "a0c2488" git-subrepo: version: "0.4.9" origin: "https://github.com/Homebrew/brew" commit: "6f293daa9f"
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
subrepo: subdir: "Examples/BushelCloud" merged: "1ab45e4" upstream: origin: "git@github.com:brightdigit/BushelCloud.git" branch: "mistkit" commit: "1ab45e4" git-subrepo: version: "0.4.9" origin: "https://github.com/Homebrew/brew" commit: "6f293daa9f"
Code Review: V1.0.0 beta.2Summary: This is a substantial feature release (36K additions, 1,121 files, 35 commits) that lands Push Notifications & Subscriptions, Zone API additions (createZone/deleteZone/fetchAllZoneChanges), auto-chunking batch conveniences, asset rereference, APNs token operations, and a comprehensive Positive Highlights
Concerns1. Breaking platform version bump — document clearly in release notes
The 2.
|
2 participants
No description provided.