fix: enable transfers, testutils feature gate, AccountStatus ordering, scaffold native_transfer#60
Merged
phertyameen merged 1 commit intoMay 30, 2026
Conversation
…ffold native_transfer - Issue bridgelet-org#42: uncomment `mod transfers` in sweep_controller and replace the dead-commented transfer block with a proper loop over `info.payments` using `transfers::TransferContext` - Issue bridgelet-org#43: add `[features] testutils = ["soroban-sdk/testutils"]` to bridgelet-shared, and add `bridgelet-shared = { features = ["testutils"] }` to dev-dependencies in ephemeral_account, sweep_controller, and reserve_contract - Issue bridgelet-org#44: add `PartialOrd, Ord` to AccountStatus derive so contracts can do ordered comparisons against the `#[repr(u32)]` state progression - Issue bridgelet-org#48: scaffold contracts/native_transfer with Cargo.toml, src/lib.rs, src/errors.rs, and src/events.rs matching the existing contract pattern; registered in workspace Cargo.toml Closes #42Closes #43Closes #44Closes bridgelet-org#48
|
@BigBen-7 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mod transfersinsweep_controller/src/lib.rsand replaced the dead-commented single-transfer block with a loop overinfo.paymentsusingtransfers::TransferContext, so every payment asset is swept on-chain.[features] testutils = ["soroban-sdk/testutils"]tobridgelet-shared/Cargo.tomland wiredbridgelet-shared = { features = ["testutils"] }intodev-dependenciesforephemeral_account,sweep_controller, andreserve_contract, fixing test-build failures across the workspace.PartialOrd, OrdtoAccountStatus's#[derive(...)]so contract logic can do ordered comparisons against the well-defined#[repr(u32)]state progression (Active → PaymentReceived → Swept → Expired).contracts/native_transfer/withCargo.toml,src/lib.rs,src/errors.rs, andsrc/events.rsmatching the existing contract pattern; registered the crate in the workspaceCargo.toml.Test plan
cargo buildpasses for the entire workspace with no errorsbridgelet-shared,ephemeral_account,sweep_controller,reserve_contract,native-transfer)emit_native_transfer_executed— no implementation yet)Closes #42
Closes #43
Closes #44
Closes #48