fix(release): repour the bottle after building it - #676
Merged
Conversation
scripts/release.sh builds the Homebrew bottle with `brew install --build-bottle' and left the machine in that state: the install receipt records built_as_bottle with poured_from_bottle false, so every later `brew install'/`reinstall'/`upgrade' of gnash on the release machine compiled from source again (and skipped post_install) instead of pouring -- the symptom reported in #671. Fresh installs on other machines were unaffected; the arm64_golden_gate bottle for 2.1.3 uploads and pours correctly. After pushing the tap, uninstall the from-source artifact and reinstall normally, so the release machine ends on the bottle it just published. Closes #671
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Diagnoses and fixes #671 (
brew install gnashcompiling from source instead of pouring).Diagnosis
arm64_golden_gate), and uploaded release asset for 2.1.3 are all correct —brew fetch brianjfox/tools/gnashdownloads the bottle, and a cleanbrew installpours it (verified:poured_from_bottle: true, no cmake run).scripts/release.shbuilds the bottle withbrew install --build-bottleand leaves that install in place. Its receipt recordsbuilt_as_bottle: true, poured_from_bottle: false, and Homebrew re-applies that state on every laterinstall/reinstall/upgrade— so gnash kept compiling from source (and skippedpost_installwith "Not running 'post_install' as we're building a bottle").Fix
release.shnow finishes by uninstalling the--build-bottleartifact and reinstalling normally after the tap is pushed, so the release machine ends on the bottle it just published. Guarded by--skip-bottle.gnash-2.1.3.arm64_golden_gate.bottle.tar.gz.bash -npasses on the script.Closes #671
🤖 Generated with Claude Code