Enable css-validation feature by default to fix :has-text() selector#609
Open
fresh3nough wants to merge 1 commit intobrave:masterfrom
Open
Enable css-validation feature by default to fix :has-text() selector#609fresh3nough wants to merge 1 commit intobrave:masterfrom
fresh3nough wants to merge 1 commit intobrave:masterfrom
Conversation
The :has-text() selector and other procedural operators were not working because the css-validation feature was not enabled by default. Without this feature, all selectors are treated as plain CSS instead of being properly parsed to extract procedural operators. This fix enables css-validation as a default feature, allowing :has-text() and other procedural selectors to work correctly. Fixes brave#537 Signed-off-by: fresh3nough <fresh3nough@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
:has-text()selector and other procedural operators were not working because thecss-validationfeature was not enabled by default. Without this feature, all selectors are treated as plain CSS instead of being properly parsed to extract procedural operators.This fix enables
css-validationas a default feature, allowing:has-text()and other procedural selectors to work correctly.Fixes #537
Note: This is a re-opening of #588, which was accidentally closed.