Skip to content

feat: Bump support for cursor SDK - #2742

Merged
Luca Forstner (lforst) merged 3 commits into
mainfrom
lforst/dum-e/nairobi-c2f387ad3d
Nov 5, 2026
Merged

Luca Forstner (lforst) merged 3 commits into
mainfrom
lforst/dum-e/nairobi-c2f387ad3d

Conversation

@lforst

Copy link
Copy Markdown
Member

No description provided.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-05T17:24:01.912678Z 9cb9390 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9cb93908b7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "Codex (@codex) review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".

Comment on lines +272 to +276
body: args.responseBody.length
? encodeBinaryDraft(
args.responseBody,
headerValue(args.responseHeaders["content-type"]),
)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve redaction for textual streaming responses

When a streamingRequests endpoint returns genuine text, JSON, or SSE containing credentials, encoding every nonempty response as a binary draft bypasses the default paranoid body redaction. applyResponseRedaction leaves binary drafts unchanged, whereas the previous bodyFromBytes path classified responses below the external-blob threshold as text/JSON/SSE and masked credential fields and token patterns. Such credentials are now persisted verbatim in committed blob sidecars. Preserve binary protobuf bytes without disabling redaction for supported textual streams, and keep chunk sizes consistent with any redacted payload.

Useful? React with 👍 / 👎.

@lforst
Luca Forstner (lforst) merged commit 0c00282 into main Nov 5, 2026
61 checks passed
@lforst
Luca Forstner (lforst) deleted the lforst/dum-e/nairobi-c2f387ad3d branch November 5, 2026 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants