[MEM] Decouple process_inverse_2018 from process_inverse_mem#894
Open
Edouard2laire wants to merge 1 commit intobrainstorm-tools:masterfrom
Open
[MEM] Decouple process_inverse_2018 from process_inverse_mem#894Edouard2laire wants to merge 1 commit intobrainstorm-tools:masterfrom
Edouard2laire wants to merge 1 commit intobrainstorm-tools:masterfrom
Conversation
Edouard2laire
commented
Mar 3, 2026
Edouard2laire
commented
Mar 3, 2026
For new version of Best (3.2.0), delegate all computation to process_inverse_mem
Edouard2laire
force-pushed
the
MEM-branch
branch
from
faba83d to
de06b83
Compare
Collaborator
Author
|
Ok. I updated the PR so it doesn't affect users who don't update the Best toolbox while delegating the computation for users who do update the toolbox. This can now be merged safely. I will merge the other PR early next week |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to better separate the code between MEM (process_inverse_MEM and process_inverse_2018). After version 3.2.0, all the computation is done inside process_inverse_MEM.
After version 3.2.0, all the main code of MEM resides in process_inverse_mem without a call to process_inverse_2018.
This is helpful so that: