feat(umbrella): typed spec.componentValues - configure any component through the umbrella#30
Merged
Merged
Conversation
…h the umbrella
The umbrella emitted every component with a hardcoded spec: {}, so you could not
configure a component when deploying via the Openstack Composition - only via a
standalone per-component Composition. Add spec.componentValues: a map keyed by
component name whose value becomes that component's Composition spec.
Crucially it is STRICTLY TYPED: hack/gen-componentvalues-schema.py merges every
component's own values.schema.json under componentValues.properties.<name> (required
stripped - it's a partial override), so e.g. componentValues.neutron.network.interface.
tunnel is a validated field that crdgen turns into the Openstack CRD and the Portal
renders a form for - not an untyped additionalProperties/preserve-unknown-fields blob.
Named componentValues (not 'overrides') to avoid clashing with OSH's own conf-override
concept; mirrors braghettos/installer hack/gen-componentvalues-schema.py.
CI (lint.yaml) regenerates the schema and fails on drift, tying it to the component
schemas. Validated: valid override accepted + passed through to the Composition spec,
unknown component rejected by additionalProperties:false, lint clean, deterministic.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem (raised by @braghettos): the umbrella emitted every component with a hardcoded
spec: {}, so you could not configure a component when deploying via theOpenstackComposition — only by dropping to a standalone per-component Composition.Fix:
spec.componentValues— a map keyed by component name whose value becomes that component's Composition spec. Strictly typed:hack/gen-componentvalues-schema.pymerges every component's ownvalues.schema.jsonundercomponentValues.properties.<name>(requiredstripped — partial override), socomponentValues.neutron.network.interface.tunnelis a validated field crdgen turns into the Openstack CRD (+ Portal form), not an untypedadditionalProperties/preserve-unknown-fieldsblob. NamedcomponentValues(notoverrides) to avoid OSH's conf-override concept; mirrors thebraghettos/installergenerator.CI regenerates the schema and fails on drift. Validated: valid override accepted + passed through; unknown component rejected; lint clean; deterministic.
🤖 Generated with Claude Code