Repository navigation
Refactor or-pattern type checking by category - #85
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Or-pattern checking now dispatches by literal, tag-shaped, and structural category. Literal alternatives constrain the scrutinee without constructing binding environments; tag and structural alternatives share explicit rules requiring identical binding names, unique names within each alternative, and unifiable binding types.
Issue #74 predates #75 (merged in PR #82), which enabled tag and structural alternatives. This refactor preserves those supported shapes and their existing rejection diagnostics rather than disabling them. Constructor heads still resolve through the ordinary pattern binder, including positional struct syntax.
Adds category unit coverage, execution cases for string/float/bool and nested/mixed alternatives, and a structural binding-type rejection fixture. Rebuilds the tracked compiler.
Validation:
bootstrap/self-test(12 passed)bootstrap/corpus-check(including AddressSanitizer and leak checks)bootstrap/bootstrap-checkbootstrap/check-seedbootstrap/fmt-checkgit diff --checkCloses #74