Normalize NVIDIA library paths to /usr/lib/#919
Open
maherthomsi wants to merge 2 commits into
Open
Conversation
maherthomsi
changed the title
maherthomsi
force-pushed
the
nvidia-normalization
branch
2 times, most recently
from
cf2022c to
7614bfc
Compare
Contributor
Author
|
Added |
piyush-jena
reviewed
May 7, 2026
piyush-jena
reviewed
May 7, 2026
piyush-jena
reviewed
May 7, 2026
maherthomsi
force-pushed
the
nvidia-normalization
branch
2 times, most recently
from
64e28c4 to
d3f12f0
Compare
Add --additional-symlinks flag to nvidia-ctk cdi generate that creates symlinks in a specified directory pointing to each discovered library. Configure generate-cdi-specs.service with: - --driver-root /x86_64-bottlerocket-linux-gnu/sys-root - --dev-root / - --additional-symlinks /usr/lib/nvidia/tesla This ensures libraries appear at /usr/lib/ in containers with backwards-compat symlinks at /usr/lib/nvidia/tesla/. Signed-off-by: Maher Homsi <maherhom@amazon.com>
…rmalization Set containerDriverRoot to the Bottlerocket sysroot path so the device plugin discovers libraries correctly and generates CDI specs with normalized /usr/lib/ container paths. Add --additional-symlinks support patches (1002, 1003) to the device plugin vendored nvidia-container-toolkit code. Signed-off-by: Maher Homsi <maherhom@amazon.com>
maherthomsi
force-pushed
the
nvidia-normalization
branch
from
d3f12f0 to
b16ac81
Compare
piyush-jena
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge with bottlerocket-os/bottlerocket-kernel-kit#425
Description of changes:
Normalize NVIDIA library paths in containers so libraries appear at
/usr/lib/instead of the Bottlerocket cross-compilation sysroot path (/x86_64-bottlerocket-linux-gnu/sys-root/usr/lib/).--additional-symlinksflag patch to nvidia-ctk cdi generate that creates backwards-compatibility symlinks in a specified directory pointing to each discovered library. Configure generate-cdi-specs.service with--driver-root,--dev-root, and--additional-symlinks /usr/lib/nvidia/tesla./usr/lib/container paths.Result: containers see libraries at
/usr/lib/libcuda.so.580.126.09with backwards-compat symlinks at/usr/lib/nvidia/tesla/libcuda.so.580.126.09→/usr/lib/libcuda.so.580.126.09.Testing done:
/usr/lib/(not sysroot path)/usr/lib/nvidia/tesla/→/usr/lib/Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.