Skip to content

Fix '&rest' handling #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
slburson wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix '&rest' handling #18

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
28ff622
Fix '&rest' handling
May 20, 2026
3d11061
Untabify branch
Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions src/iffi/function.lisp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,11 @@
(if (null param-config)
doc
(with-output-to-string (out)
(let ((*print-case* :downcase))
(let ((*print-case* :downcase)
(rest-p nil))
(when (eq (car (last param-config)) '&rest)
(setq param-config (butlast param-config))
(setq rest-p t))
(format out "Adapted result: ")
(prin1 return-type out)
(format out "~&Adapted parameters:")
Expand All @@ -133,6 +137,8 @@
(prin1 type out)
(format out " ")
(princ name out))
(when rest-p
(format out "~&..."))
(format out "~&~%~A" doc)))))


Expand Down Expand Up @@ -160,7 +166,7 @@
'(:const))
(loop for param in param-config
if (eq param '&rest)
collect '&rest
collect ''&rest
else
collect
(destructuring-bind (cffi-type
Expand All @@ -178,8 +184,7 @@
(cffi:defcfun (,mangled ,cfun-name ,@(nreverse cffi-opts)) ,return-type
,@(when doc
(list doc))
,@(loop for (param-name type) in param-config
collect `(,param-name ,type)))
,@param-config)
(meta-eval
(setf (intricate-function ',name ,@signed-param-types) ',cfun-name))
,@(when pointer-extractor
Expand Down