Add Activate on launch feature to SS3#3
Open
gonlad-x wants to merge 2 commits into
Open
Conversation
Port TarnishedTool's Activate On Launch feature: ActivateOnLaunchManager for persisted settings storage, per-tool feature checklist, and the same lifecycle-driven architecture as TarnishedTool/SekiroTool - a master enable toggle, a singleton settings window (viewmodel injected via constructor, DataContext set internally) opened via a bound command from SettingsViewModel with reuse/Activate() instead of spawning duplicates, and AppStart/Attached/Loaded/OnNewGameStart state subscriptions matching the reference implementation.
Enabling target-lock hooks conceptually belongs to when the game is actually loaded into a session, not at tool boot before any game state exists - matching where the rest of Loaded-gated, session-dependent Activate On Launch options already live.
Author
|
One thing I just realized is that if you close the tool without unchecking your activated options, they will remain activated until you quit the game. But from my testing this also happens with the current |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same implementation as TarnishedTool. Tested, all seemed to behave as expected.